Remove the concept of primitive value types and follow-up JIT/TypedReference/arglist cleanup by Copilot · Pull Request #127894 · dotnet/runtime

Copilot · 2026-05-07T00:33:27Z

Primitive value types were vestiges of very old x86 calling convention handling that became unnecessary many years ago.

This change deletes the concept of primitive value types. We only have primitives (Int32, etc. including enums) and true primitives (Int32, etc. without enums) now. Deleting this concept enabled follow-up cleanup:

Changes Made

Delete GetVerifierCorElementType and replace all call sites with GetInternalCorElementType
Remove special-casing of runtime handle structs (RuntimeArgumentHandle, RuntimeMethodHandleInternal, RuntimeFieldHandleInternal) in the type loader
Stop treating TypedReference as primitive some of the time. TypedReference is a regular byref-like value type now
Add explicit ELEMENT_TYPE_TYPEDBYREF handling in ZapSig::CompareSignatureToTypeHandle so TypedReference matching does not rely on GetSignatureCorElementType() returning ELEMENT_TYPE_TYPEDBYREF
Fix CEE_ARGLIST import the JIT to produce actual RuntimeArgumentHandle struct
Delete the unused EmitArgIteratorCreateAndLoad
Add a managed arglist regression in src/tests/JIT/Directed/arglist/varargmanaged.cs / vararg.cs that verifies a vararg method can capture RuntimeArgumentHandle, pass it to another method, and that the other method can iterate the forwarded arguments using ArgIterator
Delete the invalid arglist tests that assumed RuntimeArgumentHandle could be implicitly converted to a pointer

…gory to enum Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas

@copilot

dotnet-policy-service · 2026-05-07T00:57:42Z

Tagging subscribers to this area: @agocke
See info in area-owners.md if you want to be subscribed.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas

@copilot

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/4ef6b0df-8fc1-41d6-afe1-1119ff0f3c32 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 30 out of 30 changed files in this pull request and generated no new comments.

jkotas · 2026-05-21T00:17:23Z

@copilot Delete EmitArgIteratorCreateAndLoad - it looks like dead code

jkotas · 2026-05-21T00:29:42Z

@copilot Add a test case to src\tests\JIT\Directed\arglist\varargmanaged.cs that verifies that vararg method can take RuntimeArgumentHandle, pass it to other method as an argument and the other method can then iterate the arguments using ArgIterator

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/18226290-9256-4617-8724-756a9b93ec39 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-21T00:42:24Z

@copilot Delete EmitArgIteratorCreateAndLoad - it looks like dead code

Done in 732d054. EmitArgIteratorCreateAndLoad was unused, so I removed the dead declaration and definition and verified the cleanup with the required baseline ./build.sh clr+libs+host plus an incremental ./build.sh clr rebuild.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/3093cf8e-f9ea-474c-86ee-68898f201c85 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-21T01:09:00Z

@copilot Add a test case to src\tests\JIT\Directed\arglist\varargmanaged.cs that verifies that vararg method can take RuntimeArgumentHandle, pass it to other method as an argument and the other method...

Done in b45f413. I added a managed arglist regression that captures RuntimeArgumentHandle in one vararg method, passes it to a second method, and verifies that ArgIterator can still iterate the forwarded arguments. I also built vararg_TargetWindows.csproj and the JIT/Directed/arglist subtree successfully; I couldn’t execute the new case here because this test is Windows-only.

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/40431d8a-04a1-4e7d-8bb8-69b9c65cdf35 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas · 2026-05-21T05:06:04Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-05-21T05:06:24Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2026-05-21T05:10:33Z

manual validation of C++/CLI, notably the behavior of using a vararg, and the behavior when you pass a valist to another function.

Managed C++/CLI does not support managed varargs. I get errors like:

1>C:\ConsoleApp\ClassLibrary1\ClassLibrary1\ClassLibrary1.h(9,1): warning C4793: '`anonymous namespace'::A': function compiled as native:
1>C:\ConsoleApp\ClassLibrary1\ClassLibrary1\ClassLibrary1.h(9,1): warning C4793: 	varargs not supported under /clr

I have added a C# test that validates passing RuntimeArgumentHandle as an argument.

jkotas · 2026-05-21T07:25:33Z

@copilot Delete all arglist tests under src\tests\JIT\Directed\PREFIX\unaligned and src\tests\JIT\Directed\PREFIX\volatile. They are invalid tests (they assume that RuntimeArgumentHandle can be implicitly converted to a pointer).

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/69b984b8-312c-4a70-b684-cacff512abe8 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot · 2026-05-21T07:52:00Z

@copilot Delete all arglist tests under src\tests\JIT\Directed\PREFIX\unaligned and src\tests\JIT\Directed\PREFIX\volatile. They are invalid tests (they assume that RuntimeArgumentHandle can be implic...

Done in fadeaed. I deleted the invalid arglist tests under src/tests/JIT/Directed/PREFIX/unaligned and src/tests/JIT/Directed/PREFIX/volatile, then regenerated the checked test layout and rebuilt the affected PREFIX trees. No UI changes.

jkotas · 2026-05-21T07:53:43Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-05-21T07:53:59Z

Azure Pipelines successfully started running 1 pipeline(s).

jkotas · 2026-05-21T07:56:22Z

/azp run runtime-coreclr outerloop

azure-pipelines · 2026-05-21T07:56:42Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 50 out of 50 changed files in this pull request and generated no new comments.

jkotas · 2026-05-21T17:14:29Z

/ba-g timeouts

Copilot AI and others added 2 commits May 7, 2026 00:21

Remove verifier element type API and rename primitive-value-type cate…

7d196a3

…gory to enum Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Rename enum category in cDAC contracts/docs and clean related comments

0af6cad

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/5e928e4d-026c-49f8-a093-001b6bf1d69c Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI assigned Copilot and jkotas May 7, 2026

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 00:33

Copilot created this pull request from a session on behalf of jkotas May 7, 2026 00:34 View session

Copilot finished work on behalf of jkotas May 7, 2026 00:34

Copilot AI requested a review from jkotas May 7, 2026 00:34

jkotas reviewed May 7, 2026

View reviewed changes

Copilot started work on behalf of jkotas May 7, 2026 00:56 View session

github-actions Bot added the area-VM-coreclr label May 7, 2026

jkotas mentioned this pull request May 7, 2026

[cDAC] implement DacDbi GetTypeLayout/GetArrayLayout #127877

Merged

Address review feedback on enum/primitive category values and comments

fbca1de

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:35

Refine RuntimeHelpers primitive checks after review tool feedback

2bdd2da

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:43

Clarify primitive/enum mask behavior comment in MethodTable

4a179b3

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/a5ef9c79-9897-4019-af57-7543f1af7c54 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 7, 2026 01:46

Copilot AI changed the title ~~Delete primitive value type category concept from runtime~~ Remove primitive value type concept and normalize enum/primitive category flags May 7, 2026

Copilot finished work on behalf of jkotas May 7, 2026 01:47

Copilot AI requested a review from jkotas May 7, 2026 01:47

jkotas reviewed May 7, 2026

View reviewed changes

Copilot started work on behalf of jkotas May 7, 2026 02:20 View session

Apply latest enum/primitive review suggestions across runtime and cDAC

53d2152

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/4ef6b0df-8fc1-41d6-afe1-1119ff0f3c32 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 7, 2026 02:55

Fix build break

091d2be

Copilot AI reviewed May 20, 2026

View reviewed changes

Potential fix for pull request finding

8c618c7

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

jkotas reviewed May 20, 2026

View reviewed changes

Comment thread ...coreclr/System.Private.CoreLib/src/System/Runtime/CompilerServices/RuntimeHelpers.CoreCLR.cs Outdated

Apply suggestion from @jkotas

6003adb

Copilot AI reviewed May 20, 2026

View reviewed changes

Delete dead EmitArgIteratorCreateAndLoad helper

732d054

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/18226290-9256-4617-8724-756a9b93ec39 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

jkotas reviewed May 21, 2026

View reviewed changes

Comment thread src/coreclr/vm/stubgen.cpp

Add arglist RuntimeArgumentHandle regression test

b45f413

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/3093cf8e-f9ea-474c-86ee-68898f201c85 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Remove stale ArgIterator CTOR2 corelib entry

bb9fd60

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/40431d8a-04a1-4e7d-8bb8-69b9c65cdf35 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Delete invalid PREFIX arglist tests

fadeaed

Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/69b984b8-312c-4a70-b684-cacff512abe8 Co-authored-by: jkotas <6668460+jkotas@users.noreply.github.com>

Merge branch 'main' into copilot/delete-primitive-value-types

12c1099

Copilot AI reviewed May 21, 2026

View reviewed changes

build-analysis Bot mentioned this pull request May 21, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

3 tasks

davidwrighton approved these changes May 21, 2026

View reviewed changes

dotnet-maestro Bot mentioned this pull request May 22, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#6764

Merged

Conversation

Copilot AI commented May 7, 2026 • edited by jkotas Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dotnet-policy-service Bot commented May 7, 2026

Uh oh!

jkotas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jkotas commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026

Uh oh!

Uh oh!

Copilot AI commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

azure-pipelines Bot commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

Copilot AI commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

azure-pipelines Bot commented May 21, 2026

Uh oh!

jkotas commented May 21, 2026

Uh oh!

azure-pipelines Bot commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

jkotas commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Copilot AI commented May 7, 2026 •

edited by jkotas

Loading