Skip to content

Use ThrowHelper in JsonElement.GetByte/GetSByte/GetInt16/GetUInt16 #126559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prozolic wants to merge 3 commits into
base: main
Choose a base branch
from
+12 −12
Open

Use ThrowHelper in JsonElement.GetByte/GetSByte/GetInt16/GetUInt16 #126559

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9fbe86c
Use ThrowHelper in JsonElement.GetByte/GetSByte/GetInt16/GetUInt16
prozolic Apr 5, 2026
b3d7cdd
Merge branch 'main' into jsonelementget
prozolic Apr 5, 2026
4156243
Merge branch 'main' into jsonelementget
prozolic Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions src/libraries/System.Text.Json/src/System/Text/Json/Document/JsonElement.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -473,12 +473,12 @@ public bool TryGetSByte(out sbyte value)
[CLSCompliant(false)]
public sbyte GetSByte()
{
if (TryGetSByte(out sbyte value))
if (!TryGetSByte(out sbyte value))
{
return value;
ThrowHelper.ThrowFormatException();
}

throw new FormatException();
return value;
}

/// <summary>
Expand Down Expand Up @@ -523,12 +523,12 @@ public bool TryGetByte(out byte value)
/// </exception>
public byte GetByte()
{
if (TryGetByte(out byte value))
if (!TryGetByte(out byte value))
{
return value;
ThrowHelper.ThrowFormatException();
}

throw new FormatException();
return value;
}

/// <summary>
Expand Down Expand Up @@ -570,12 +570,12 @@ public bool TryGetInt16(out short value)
/// </exception>
public short GetInt16()
{
if (TryGetInt16(out short value))
if (!TryGetInt16(out short value))
{
return value;
ThrowHelper.ThrowFormatException();
}

throw new FormatException();
return value;
}

/// <summary>
Expand Down Expand Up @@ -622,12 +622,12 @@ public bool TryGetUInt16(out ushort value)
[CLSCompliant(false)]
public ushort GetUInt16()
{
if (TryGetUInt16(out ushort value))
if (!TryGetUInt16(out ushort value))
{
return value;
ThrowHelper.ThrowFormatException();
}

throw new FormatException();
return value;
}

/// <summary>
Expand Down
Loading