Replace MethodDescCallSite with UnmanagedCallersOnly in clrex.cpp by AaronRobinsonMSFT · Pull Request #126061 · dotnet/runtime

AaronRobinsonMSFT · 2026-03-24T23:03:01Z

Note

This PR description was generated with the assistance of GitHub Copilot.

Convert exception construction in clrex.cpp from MethodDescCallSite/CallDescrWorker to the UnmanagedCallersOnlyCaller pattern for EEArgumentException, EETypeLoadException, and EEFileLoadException.

Changes

Exception.CoreCLR.cs - Add [UnmanagedCallersOnly] CreateArgumentException factory method
FileLoadException.CoreCLR.cs - Add [UnmanagedCallersOnly] Create factory method
TypeLoadException.CoreCLR.cs - Add [UnmanagedCallersOnly] Create factory method
clrex.cpp - Replace MethodDescCallSite usage with UnmanagedCallersOnlyCaller in three CreateThrowable methods
corelib.h - Register new managed methods (METHOD__EXCEPTION__CREATE_ARGUMENT_EXCEPTION, METHOD__TYPE_LOAD_EXCEPTION__CREATE, METHOD__FILE_LOAD_EXCEPTION__CREATE)
metasig.h - Remove unused metasig entries (IM(Str_Int_RetVoid), IM(Str_Str_Str_Int_RetVoid))

Contributes to #123864

Convert EEArgumentException, EETypeLoadException, and EEFileLoadException CreateThrowable methods to use UnmanagedCallersOnlyCaller instead of MethodDescCallSite/CallDescrWorker for invoking managed exception constructors. Add corresponding [UnmanagedCallersOnly] factory methods in managed code and remove unused metasig entries. Contributes to dotnet#123864 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

This PR migrates several VM-to-managed exception construction paths in src/coreclr/vm/clrex.cpp from MethodDescCallSite / CallDescrWorker to the UnmanagedCallersOnlyCaller reverse P/Invoke pattern, adding the corresponding [UnmanagedCallersOnly] managed factory entrypoints and binder registrations in CoreLib.

Changes:

Add [UnmanagedCallersOnly] managed factory methods for ArgumentException, TypeLoadException, and FileLoadException construction.
Update clrex.cpp to invoke these factories via UnmanagedCallersOnlyCaller instead of MethodDescCallSite.
Register new CoreLib binder method IDs and remove now-unused metasig entries.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
src/coreclr/vm/metasig.h	Removes metasig entries no longer needed after dropping `MethodDescCallSite` ctor invocations.
src/coreclr/vm/corelib.h	Adds binder registrations for the new managed `[UnmanagedCallersOnly]` factory methods.
src/coreclr/vm/clrex.cpp	Switches three `CreateThrowable()` implementations to `UnmanagedCallersOnlyCaller`.
src/coreclr/System.Private.CoreLib/src/System/TypeLoadException.CoreCLR.cs	Adds `[UnmanagedCallersOnly] TypeLoadException.Create` factory.
src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs	Adds `[UnmanagedCallersOnly] FileLoadException.Create` factory.
src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs	Adds `[UnmanagedCallersOnly] Exception.CreateArgumentException` helper for ctor invocation.

src/coreclr/vm/clrex.cpp

src/coreclr/vm/corelib.h

src/coreclr/vm/clrex.cpp

src/coreclr/System.Private.CoreLib/src/System/TypeLoadException.CoreCLR.cs

src/coreclr/vm/clrex.cpp

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs

Refactor EEFileLoadException::GetFileLoadKind to use a switch statement. Add ArgumentExceptionKind and FileLoadExceptionKind enums for managed mapping. Update CreateThrowable methods to use UnmanagedCallersOnlyCaller. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs

…tion.CoreCLR.cs

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

…co-conversion

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

src/coreclr/vm/clrex.cpp

…ate reverse thunk mappings

AaronRobinsonMSFT · 2026-03-26T21:15:43Z

/azp run runtime

AaronRobinsonMSFT · 2026-03-26T23:52:33Z

/azp run runtime

azure-pipelines · 2026-03-26T23:53:01Z

Azure Pipelines successfully started running 1 pipeline(s).

Copilot

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

src/coreclr/vm/clrex.cpp

src/native/libs/Common/JavaScript/loader/dotnet.d.ts

AaronRobinsonMSFT · 2026-03-28T23:45:49Z

/ba-g Unrelated failure

Copilot AI review requested due to automatic review settings March 24, 2026 23:03

github-actions bot added the area-ExceptionHandling-coreclr label Mar 24, 2026

dotnet-policy-service bot assigned AaronRobinsonMSFT Mar 24, 2026

github-project-automation bot added this to AppModel Mar 24, 2026

Copilot started reviewing on behalf of AaronRobinsonMSFT March 24, 2026 23:03 View session

AaronRobinsonMSFT mentioned this pull request Mar 24, 2026

Replace MethodDescCallSite instances with UnmanagedCallersOnlyAttribute pattern #123864

Open

65 tasks

AaronRobinsonMSFT requested review from jkoritzinsky and jkotas March 24, 2026 23:07

AaronRobinsonMSFT added this to the 11.0.0 milestone Mar 24, 2026

Copilot AI reviewed Mar 24, 2026

View reviewed changes

src/coreclr/vm/clrex.cpp Outdated Show resolved Hide resolved

src/coreclr/vm/corelib.h Show resolved Hide resolved

src/coreclr/vm/clrex.cpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 24, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/TypeLoadException.CoreCLR.cs Show resolved Hide resolved

jkotas reviewed Mar 24, 2026

View reviewed changes

src/coreclr/vm/clrex.cpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 24, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

jkotas approved these changes Mar 25, 2026

View reviewed changes

build-analysis bot mentioned this pull request Mar 25, 2026

Unable to pull image from mcr.microsoft.com #117164

Open

Apply suggestions from code review

69e543a

Co-authored-by: Jan Kotas <jkotas@microsoft.com>

Copilot AI review requested due to automatic review settings March 25, 2026 17:24

Copilot started reviewing on behalf of AaronRobinsonMSFT March 25, 2026 17:25 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs Show resolved Hide resolved

AaronRobinsonMSFT commented Mar 25, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs Show resolved Hide resolved

Update src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadExcep…

7ea059c

…tion.CoreCLR.cs

Copilot AI review requested due to automatic review settings March 25, 2026 20:56

Copilot started reviewing on behalf of AaronRobinsonMSFT March 25, 2026 20:57 View session

Copilot AI reviewed Mar 25, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Show resolved Hide resolved

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT commented Mar 25, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/IO/FileLoadException.CoreCLR.cs Outdated Show resolved Hide resolved

AaronRobinsonMSFT commented Mar 25, 2026

View reviewed changes

src/coreclr/System.Private.CoreLib/src/System/Exception.CoreCLR.cs Outdated Show resolved Hide resolved

Apply suggestions from code review

a0894f7

Co-authored-by: Aaron R Robinson <arobins@microsoft.com>

Copilot AI review requested due to automatic review settings March 25, 2026 21:13

Refactor exception kind switch statements for improved readability

0ca38bb

Copilot AI review requested due to automatic review settings March 26, 2026 18:04

Copilot started reviewing on behalf of AaronRobinsonMSFT March 26, 2026 18:05 View session

jkotas approved these changes Mar 26, 2026

View reviewed changes

Merge remote-tracking branch 'upstream/main' into dev/arobins/clrex-u…

c9d136e

…co-conversion

Copilot AI reviewed Mar 26, 2026

View reviewed changes

src/coreclr/vm/clrex.cpp Show resolved Hide resolved

src/coreclr/vm/clrex.cpp Show resolved Hide resolved

src/coreclr/vm/clrex.cpp Show resolved Hide resolved

Add new call helpers for FileLoadException and TypeLoadException; upd…

52f5785

…ate reverse thunk mappings

AaronRobinsonMSFT closed this Mar 26, 2026

AaronRobinsonMSFT reopened this Mar 26, 2026

This was referenced Mar 27, 2026

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

runtime / Build / maccatalyst-x64 release MonoAOTOffsets / Build product failure #120116

Open

Merge branch 'main' into dev/arobins/clrex-uco-conversion

50d1604

Copilot AI review requested due to automatic review settings March 27, 2026 17:26

Copilot started reviewing on behalf of AaronRobinsonMSFT March 27, 2026 17:28 View session

Copilot AI reviewed Mar 27, 2026

View reviewed changes

src/coreclr/vm/clrex.cpp Show resolved Hide resolved

jkotas reviewed Mar 27, 2026

View reviewed changes

src/native/libs/Common/JavaScript/loader/dotnet.d.ts Show resolved Hide resolved

Merge branch 'main' into dev/arobins/clrex-uco-conversion

bd26311

AaronRobinsonMSFT merged commit ff21bcd into dotnet:main Mar 28, 2026
161 of 163 checks passed

AaronRobinsonMSFT deleted the dev/arobins/clrex-uco-conversion branch March 28, 2026 23:46

github-project-automation bot moved this to Done in AppModel Mar 28, 2026

dotnet-maestro bot mentioned this pull request Mar 29, 2026

[main] Source code updates from dotnet/runtime dotnet/dotnet#5757

Merged

Conversation

AaronRobinsonMSFT commented Mar 24, 2026

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Mar 26, 2026

Uh oh!

AaronRobinsonMSFT commented Mar 26, 2026

Uh oh!

azure-pipelines bot commented Mar 26, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Mar 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants