Skip to content

[wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets#126019

Open
radekdoulik wants to merge 2 commits intodotnet:mainfrom
radekdoulik:disable-structinreg-pinvoke
Open

[wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets#126019
radekdoulik wants to merge 2 commits intodotnet:mainfrom
radekdoulik:disable-structinreg-pinvoke

Conversation

@radekdoulik
Copy link
Member

Note

This PR description was AI/Copilot-generated.

Summary

Disables the structinreg P/Invoke test until native linking is ready on wasm/coreclr. The test uses [DllImport("jitstructtests_lib")] which requires native test assets.

Tracked by #123946

…sets

The test is disabled until native linking is ready on wasm/coreclr.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@radekdoulik radekdoulik added this to the Future milestone Mar 24, 2026
Copilot AI review requested due to automatic review settings March 24, 2026 10:20
@radekdoulik radekdoulik requested a review from maraf March 24, 2026 10:20
@dotnet-policy-service
Copy link
Contributor

Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

@radekdoulik radekdoulik changed the title Disable structinreg P/Invoke test on platforms without native test assets [wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets Mar 24, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Disables the structinreg System V bring-up test entrypoint on platforms that currently don’t support native test assets (required due to DllImport("jitstructtests_lib") usage in the test suite), aligning with the infra limitations tracked in #123946.

Changes:

  • Adds an [ActiveIssue] guard to skip the test when PlatformDetection.PlatformDoesNotSupportNativeTestAssets is true.
  • Adds a TestLibrary using to support the new platform detection reference.

Comment on lines 4 to 6
using System.Runtime.CompilerServices;
using TestLibrary;
using Xunit;
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using TestLibrary; is currently unused because the attribute references TestLibrary.PlatformDetection with a fully-qualified name. This will introduce an unnecessary using directive (and can trigger CS8019 in some builds). Remove the using, or simplify the attribute to use typeof(PlatformDetection) / nameof(PlatformDetection.PlatformDoesNotSupportNativeTestAssets) so the using is actually needed.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants