[wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets#126019
[wasm][coreclr] Disable structinreg P/Invoke test on platforms without native test assets#126019radekdoulik wants to merge 2 commits intodotnet:mainfrom
Conversation
…sets The test is disabled until native linking is ready on wasm/coreclr. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure |
There was a problem hiding this comment.
Pull request overview
Disables the structinreg System V bring-up test entrypoint on platforms that currently don’t support native test assets (required due to DllImport("jitstructtests_lib") usage in the test suite), aligning with the infra limitations tracked in #123946.
Changes:
- Adds an
[ActiveIssue]guard to skip the test whenPlatformDetection.PlatformDoesNotSupportNativeTestAssetsis true. - Adds a
TestLibraryusing to support the new platform detection reference.
| using System.Runtime.CompilerServices; | ||
| using TestLibrary; | ||
| using Xunit; |
There was a problem hiding this comment.
using TestLibrary; is currently unused because the attribute references TestLibrary.PlatformDetection with a fully-qualified name. This will introduce an unnecessary using directive (and can trigger CS8019 in some builds). Remove the using, or simplify the attribute to use typeof(PlatformDetection) / nameof(PlatformDetection.PlatformDoesNotSupportNativeTestAssets) so the using is actually needed.
Note
This PR description was AI/Copilot-generated.
Summary
Disables the structinreg P/Invoke test until native linking is ready on wasm/coreclr. The test uses
[DllImport("jitstructtests_lib")]which requires native test assets.Tracked by #123946