[Wasm RyuJit] Ind write barriers, direct helper calls, more #124113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AndyAyersMS
commented
Feb 6, 2026
AndyAyersMS
commented
- implement codegen for write barrier helper calls
- support direct calls to helpers
- decorate call targets with their symbolic names in dumps/disasm
* implement codegen for write barrier helper calls * support direct calls to helpers * decorate call targets with their symbolic names in dumps/disasm
Member
Author
|
fyi @dotnet/jit-contrib |
github-actions
bot
added
the
area-CodeGen-coreclr
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the CoreCLR WASM JIT backend to better support runtime helper calls and GC write barriers, and improves dump/disasm readability by annotating call targets with symbolic names.
Changes:
- Add disasm/dump decoration for call targets in
emitwasm.cppusing recorded method handles. - Implement WASM
GT_STOREINDwrite barrier codegen by routing togenGCWriteBarrier. - Enable direct helper-call emission in WASM codegen and adjust
codegencommon.cppTARGET_WASMguards to keep non-WASM-only code excluded while sharing write-barrier helpers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/emitwasm.cpp | Prints call target method names in verbose dumps/disasm when debug info is present. |
| src/coreclr/jit/codegenwasm.cpp | Adds write-barrier handling for STOREIND and emits helper calls via genEmitHelperCall. |
| src/coreclr/jit/codegencommon.cpp | Refactors TARGET_WASM preprocessor guards to share write-barrier helper selection while excluding non-WASM-only sections. |
kg
approved these changes
Feb 7, 2026
3 tasks
SingleAccretion
approved these changes
Feb 7, 2026
This was referenced Feb 7, 2026
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
…24113) * implement codegen for write barrier helper calls * support direct calls to helpers * decorate call targets with their symbolic names in dumps/disasm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.