Add runtime test for IPC profiler command validation with truncated payloads#124056
Draft
Add runtime test for IPC profiler command validation with truncated payloads#124056
Conversation
Co-authored-by: mdh1418 <16830051+mdh1418@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add runtime test for IPC profiler command validation
Add runtime test for IPC profiler command validation with truncated payloads
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds runtime tests validating that the diagnostic server properly rejects IPC profiler commands when payload fields claim more data than actually exists. This covers the
client_data_lenvalidation at line 73 ofds-profiler-protocol.cas discussed in #122257.Test cases added
AttachProfilerCommand_TruncatedClientData_ReturnsError-client_data_lenclaims 1000 bytes, provides 0StartupProfilerCommand_TruncatedString_ReturnsError-profiler_pathstring length claims 1000 chars, provides 2AttachProfilerCommand_TruncatedGuid_ReturnsError- GUID field provides 8 bytes instead of 16All tests verify the server returns
DS_IPC_E_BAD_ENCODING(0x80131384).Example payload construction
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.