Remove dead thread suspension code from PAL

eng/native/tryrun.browser.cmake

@@ -101,9 +101,6 @@ set(COMPILER_SUPPORTS_F_ALIGNED_NEW 1 CACHE INTERNAL "")
 set(COMPILER_SUPPORTS_W_IMPLICIT_FALLTHROUGH 1 CACHE INTERNAL "")
 set(COMPILER_SUPPORTS_W_PRE_C11_COMPAT 1 CACHE INTERNAL "")
 set(COMPILER_SUPPORTS_W_RESERVED_IDENTIFIER 1 CACHE INTERNAL "")
-set(HAS_POSIX_SEMAPHORES_COMPILED TRUE CACHE INTERNAL "")
-set_cache_value(HAS_POSIX_SEMAPHORES_EXITCODE 0)
-set(HAS_POSIX_SEMAPHORES 1 CACHE INTERNAL "")
 set(HAS_PTHREAD_MUTEXES 1 CACHE INTERNAL "")
 set(HAS_SYSV_SEMAPHORES "" CACHE INTERNAL "")
 set(HAVE___GREGSET_T "" CACHE INTERNAL "")
@@ -381,13 +378,7 @@ set(HAVE_YIELD_SYSCALL "" CACHE INTERNAL "")
 set(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS_COMPILED TRUE CACHE INTERNAL "")
 set_cache_value(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS_EXITCODE 1)
 set(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS "" CACHE INTERNAL "")
-set(PTHREAD_CREATE_MODIFIES_ERRNO_COMPILED TRUE CACHE INTERNAL "")
-set_cache_value(PTHREAD_CREATE_MODIFIES_ERRNO_EXITCODE 1)
-set(PTHREAD_CREATE_MODIFIES_ERRNO "" CACHE INTERNAL "")
 set(PTHREAD_RWLOCK_T 32 CACHE INTERNAL "")
 set(REALPATH_SUPPORTS_NONEXISTENT_FILES_COMPILED TRUE CACHE INTERNAL "")
 set_cache_value(REALPATH_SUPPORTS_NONEXISTENT_FILES_EXITCODE 1)
 set(REALPATH_SUPPORTS_NONEXISTENT_FILES "" CACHE INTERNAL "")
-set(SEM_INIT_MODIFIES_ERRNO_COMPILED TRUE CACHE INTERNAL "")
-set_cache_value(SEM_INIT_MODIFIES_ERRNO_EXITCODE 1)
-set(SEM_INIT_MODIFIES_ERRNO "" CACHE INTERNAL "")

eng/native/tryrun.cmake

@@ -51,7 +51,6 @@ endif()
 
 if(DARWIN AND NOT DEFINED ANDROID_BUILD)
   if(TARGET_ARCH_NAME MATCHES "^(arm64|x64)$")
-    set_cache_value(HAS_POSIX_SEMAPHORES_EXITCODE 1)
     set_cache_value(HAVE_BROKEN_FIFO_KEVENT_EXITCODE 1)
     set_cache_value(HAVE_BROKEN_FIFO_SELECT_EXITCODE 1)
     set_cache_value(HAVE_CLOCK_MONOTONIC_COARSE_EXITCODE 1)
@@ -69,15 +68,12 @@ if(DARWIN AND NOT DEFINED ANDROID_BUILD)
     set_cache_value(HAVE_WORKING_GETTIMEOFDAY_EXITCODE 0)
     set_cache_value(MMAP_ANON_IGNORES_PROTECTION_EXITCODE 1)
     set_cache_value(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS_EXITCODE 1)
-    set_cache_value(PTHREAD_CREATE_MODIFIES_ERRNO_EXITCODE 1)
     set_cache_value(REALPATH_SUPPORTS_NONEXISTENT_FILES_EXITCODE 1)
-    set_cache_value(SEM_INIT_MODIFIES_ERRNO_EXITCODE 1)
     set_cache_value(HAVE_SHM_OPEN_THAT_WORKS_WELL_ENOUGH_WITH_MMAP_EXITCODE 1)
   else()
     message(FATAL_ERROR "Arch is ${TARGET_ARCH_NAME}. Only arm64 or x64 is supported for OSX cross build!")
   endif()
 else()
-  set_cache_value(HAS_POSIX_SEMAPHORES_EXITCODE 0)
   set_cache_value(HAVE_CLOCK_MONOTONIC_COARSE_EXITCODE 0)
   set_cache_value(HAVE_CLOCK_MONOTONIC_EXITCODE 0)
   set_cache_value(HAVE_CLOCK_REALTIME_EXITCODE 0)
@@ -91,10 +87,7 @@ else()
   set_cache_value(HAVE_WORKING_CLOCK_GETTIME_EXITCODE 0)
   set_cache_value(HAVE_WORKING_GETTIMEOFDAY_EXITCODE 0)
   set_cache_value(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS_EXITCODE 1)
-  set_cache_value(PTHREAD_CREATE_MODIFIES_ERRNO_EXITCODE 1)
   set_cache_value(REALPATH_SUPPORTS_NONEXISTENT_FILES_EXITCODE 1)
-  set_cache_value(SEM_INIT_MODIFIES_ERRNO_EXITCODE 1)
-
   if(ALPINE_LINUX)
     set_cache_value(HAVE_SHM_OPEN_THAT_WORKS_WELL_ENOUGH_WITH_MMAP_EXITCODE 1)
   else()

eng/native/tryrun_ios_tvos.cmake

@@ -10,7 +10,6 @@ set_cache_value(HAVE_CLOCK_MONOTONIC_EXITCODE 0)
 
 # TODO: these are taken from macOS, check these whether they're correct for iOS
 # some of them are probably not used by what we use from NativeAOT so could be reduced
-set_cache_value(HAS_POSIX_SEMAPHORES_EXITCODE 1)
 set_cache_value(HAVE_BROKEN_FIFO_KEVENT_EXITCODE 1)
 set_cache_value(HAVE_BROKEN_FIFO_SELECT_EXITCODE 1)
 set_cache_value(HAVE_CLOCK_REALTIME_EXITCODE 0)
@@ -25,7 +24,5 @@ set_cache_value(HAVE_WORKING_CLOCK_GETTIME_EXITCODE 0)
 set_cache_value(HAVE_WORKING_GETTIMEOFDAY_EXITCODE 0)
 set_cache_value(MMAP_ANON_IGNORES_PROTECTION_EXITCODE 1)
 set_cache_value(ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS_EXITCODE 1)
-set_cache_value(PTHREAD_CREATE_MODIFIES_ERRNO_EXITCODE 1)
 set_cache_value(REALPATH_SUPPORTS_NONEXISTENT_FILES_EXITCODE 1)
-set_cache_value(SEM_INIT_MODIFIES_ERRNO_EXITCODE 1)
 set_cache_value(HAVE_SHM_OPEN_THAT_WORKS_WELL_ENOUGH_WITH_MMAP_EXITCODE 1)

src/coreclr/pal/src/config.h.in

@@ -90,17 +90,13 @@
 #cmakedefine01 HAVE_PTHREAD_CONDATTR_SETCLOCK
 #cmakedefine01 MMAP_ANON_IGNORES_PROTECTION
 #cmakedefine01 ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS
-#cmakedefine01 PTHREAD_CREATE_MODIFIES_ERRNO
-#cmakedefine01 SEM_INIT_MODIFIES_ERRNO
 #cmakedefine01 HAVE_PROCFS_CTL
 #cmakedefine01 HAVE_PROCFS_STAT
-#cmakedefine01 HAS_POSIX_SEMAPHORES
 
 #define PAL_THREAD_PRIORITY_MIN 0
 #define PAL_THREAD_PRIORITY_MAX 0
 
 #cmakedefine01 HAVE__NSGETENVIRON
-#cmakedefine01 DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX
 #cmakedefine PAL_PTRACE(cmd, pid, addr, data) @PAL_PTRACE@
 #cmakedefine01 SYNCHMGR_SUSPENSION_SAFE_CONDITION_SIGNALING
 #cmakedefine01 ERROR_FUNC_FOR_GLOB_HAS_FIXED_PARAMS

src/coreclr/pal/src/configure.cmake

@@ -497,52 +497,6 @@ int main(void)
   exit(ret != 1);
 }" ONE_SHARED_MAPPING_PER_FILEREGION_PER_PROCESS)
 
-set(CMAKE_REQUIRED_LIBRARIES pthread)
-check_cxx_source_runs("
-#include <errno.h>
-#include <pthread.h>
-#include <stdlib.h>
-
-void *start_routine(void *param) { return NULL; }
-
-int main() {
-  int result;
-  pthread_t tid;
-
-  errno = 0;
-  result = pthread_create(&tid, NULL, start_routine, NULL);
-  if (result != 0) {
-    exit(1);
-  }
-  if (errno != 0) {
-    exit(0);
-  }
-  exit(1);
-}" PTHREAD_CREATE_MODIFIES_ERRNO)
-set(CMAKE_REQUIRED_LIBRARIES)
-set(CMAKE_REQUIRED_LIBRARIES pthread)
-check_cxx_source_runs("
-#include <errno.h>
-#include <semaphore.h>
-#include <stdlib.h>
-
-int main() {
-  int result;
-  sem_t sema;
-
-  errno = 50;
-  result = sem_init(&sema, 0, 0);
-  if (result != 0)
-  {
-    exit(1);
-  }
-  if (errno != 50)
-  {
-    exit(0);
-  }
-  exit(1);
-}" SEM_INIT_MODIFIES_ERRNO)
-set(CMAKE_REQUIRED_LIBRARIES)
 check_cxx_source_runs("
 #include <fcntl.h>
 #include <stdlib.h>
@@ -566,7 +520,7 @@ int main(void) {
   }
   exit(0);
 }" HAVE_PROCFS_CTL)
-set(CMAKE_REQUIRED_LIBRARIES)
+
 check_cxx_source_runs("
 #include <fcntl.h>
 #include <stdlib.h>
@@ -592,21 +546,6 @@ int main(void) {
 }" HAVE_PROCFS_STAT)
 set(CMAKE_REQUIRED_LIBRARIES)
 
-set(CMAKE_REQUIRED_LIBRARIES ${PTHREAD_LIBRARY})
-check_cxx_source_runs("
-#include <stdlib.h>
-#include <errno.h>
-#include <semaphore.h>
-
-int main() {
-  sem_t sema;
-  if (sem_init(&sema, 0, 0) == -1){
-    exit(1);
-  }
-  exit(0);
-}" HAS_POSIX_SEMAPHORES)
-set(CMAKE_REQUIRED_LIBRARIES)
-
 set(SYNCHMGR_SUSPENSION_SAFE_CONDITION_SIGNALING 1)
 set(ERROR_FUNC_FOR_GLOB_HAS_FIXED_PARAMS 1)
 
@@ -667,12 +606,10 @@ int main(int argc, char **argv)
 
 if(CLR_CMAKE_TARGET_APPLE)
   set(HAVE__NSGETENVIRON 1)
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 1)
   set(PAL_PTRACE "ptrace((cmd), (pid), (caddr_t)(addr), (data))")
   set(HAVE_SCHED_OTHER_ASSIGNABLE 1)
 
 elseif(CLR_CMAKE_TARGET_FREEBSD)
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(PAL_PTRACE "ptrace((cmd), (pid), (caddr_t)(addr), (data))")
   if (CLR_CMAKE_HOST_ARCH_AMD64)
     set(BSD_REGS_STYLE "((reg).r_##rr)")
@@ -683,29 +620,24 @@ elseif(CLR_CMAKE_TARGET_FREEBSD)
   endif()
   set(HAVE_SCHED_OTHER_ASSIGNABLE 1)
 elseif(CLR_CMAKE_TARGET_NETBSD)
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(PAL_PTRACE "ptrace((cmd), (pid), (void*)(addr), (data))")
   set(BSD_REGS_STYLE "((reg).regs[_REG_##RR])")
   set(HAVE_SCHED_OTHER_ASSIGNABLE 0)
 
 elseif(CLR_CMAKE_TARGET_SUNOS)
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(PAL_PTRACE "ptrace((cmd), (pid), (caddr_t)(addr), (data))")
   set(SET_SCHEDPARAM_NEEDS_PRIVS 1)
 elseif(CLR_CMAKE_TARGET_HAIKU)
   # Haiku does not have ptrace.
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(HAVE_SCHED_OTHER_ASSIGNABLE 1)
 elseif(CLR_CMAKE_TARGET_BROWSER)
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(HAVE_SCHED_OTHER_ASSIGNABLE 0)
 else() # Anything else is Linux
   # LTTNG is not available on Android, so don't error out
   if(FEATURE_EVENTSOURCE_XPLAT AND NOT HAVE_LTTNG_TRACEPOINT_H)
     unset(HAVE_LTTNG_TRACEPOINT_H CACHE)
     message(FATAL_ERROR "Cannot find liblttng-ust-dev. Try installing liblttng-ust-dev  (or the appropriate packages for your platform)")
   endif()
-  set(DEADLOCK_WHEN_THREAD_IS_SUSPENDED_WHILE_BLOCKED_ON_MUTEX 0)
   set(PAL_PTRACE "ptrace((cmd), (pid), (void*)(addr), (data))")
   set(HAVE_SCHED_OTHER_ASSIGNABLE 1)
 endif(CLR_CMAKE_TARGET_APPLE)

src/coreclr/pal/src/include/pal/process.h

@@ -95,38 +95,6 @@ Return
 --*/
 VOID PROCCleanupInitialProcess(VOID);
 
-#if USE_SYSV_SEMAPHORES
-/*++
-Function:
-  PROCCleanupThreadSemIds(VOID);
-
-Abstract
-  Cleanup SysV semaphore ids for all threads.
-
-(no parameters, no return value)
---*/
-VOID PROCCleanupThreadSemIds(VOID);
-#endif
-
-/*++
-Function:
-  PROCProcessLock
-
-Abstract
-  Enter the critical section associated to the current process
---*/
-VOID PROCProcessLock(VOID);
-
-
-/*++
-Function:
-  PROCProcessUnlock
-
-Abstract
-  Leave the critical section associated to the current process
---*/
-VOID PROCProcessUnlock(VOID);
-
 /*++
 Function
   PROCAbortInitialize()

src/coreclr/pal/src/include/pal/procobj.hpp

@@ -88,11 +88,6 @@ namespace CorUnix
         LPPROCESS_INFORMATION lpProcessInformation
         );
 
-    PAL_ERROR
-    InitializeProcessData(
-        void
-        );
-
     PAL_ERROR
     InitializeProcessCommandLine(
         LPWSTR lpwstrCmdLine,