Merged
Conversation
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
SingleAccretion
force-pushed
the
WasmJit-RA
branch
from
d2a7c31 to
1bf56cd
Compare
Assign each tracked local its own virtual register. Then assign each virtual register a physical WASM local.
SingleAccretion
force-pushed
the
WasmJit-RA
branch
from
1bf56cd to
5d4045c
Compare
Contributor
Author
|
@dotnet/jit-contrib |
AndyAyersMS
reviewed
Feb 6, 2026
Member
AndyAyersMS
left a comment
AndyAyersMS
left a comment
There was a problem hiding this comment.
Changes LGTM.
Do you have any thoughts on how we'll handle things for funclets?
Their args will be something like
- arg0: SP
- arg1: parent FP
- arg2: exception object (for catch and filter)
Contributor
|
Tagging subscribers to 'arch-wasm': @lewing, @pavelsavara |
Contributor
Author
I was thinking we'd have a per-function bank of virtual registers. It will require some more metadata tracking, but it is how it is. |
AndyAyersMS
approved these changes
Feb 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign each tracked local its own virtual register then assign each virtual register a physical WASM local.
The intent here is to just get a simple & easily correct by design algorithm going so we can get to things like internal registers for bounds check and such.