Rename IDurableJobContext to IJobRunContext #9798
Open
+51
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oughout the codebase
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the interface IDurableJobContext to IDurableJobRun and the implementation class DurableJobContext to DurableJobRun throughout the Orleans durable jobs codebase. This is a refactoring change to improve naming consistency and better reflect the domain concept.
- Updates the interface, implementation class, and all references across test code, implementation code, and documentation
- Renames related methods like
GetJobContexttoGetJobRunandGetFinalJobContexttoGetFinalJobRun - Updates XML documentation comments to reference the new type names
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/Tester/DurableJobs/DurableJobTestsRunner.cs | Updated test calls to use renamed GetJobRun and GetFinalJobRun methods |
| test/NonSilo.Tests/ScheduledJobs/InMemoryJobQueueTests.cs | Updated list types and mock object creation to use IDurableJobRun |
| test/Grains/TestGrains/RetryTestGrain.cs | Updated field types, method signatures, and return types to use IDurableJobRun |
| test/Grains/TestGrains/DurableJobGrain.cs | Updated dictionary field types and method signatures to use IDurableJobRun |
| test/Grains/TestGrainInterfaces/IRetryTestGrain.cs | Updated interface method return type to use IDurableJobRun |
| test/Grains/TestGrainInterfaces/IDurableJobGrain.cs | Updated interface method return type to use IDurableJobRun |
| src/Orleans.DurableJobs/ShardExecutor.cs | Updated parameter type to use IDurableJobRun |
| src/Orleans.DurableJobs/README.md | Updated documentation examples to use IDurableJobRun in method signatures |
| src/Orleans.DurableJobs/JobShard.cs | Updated interface and implementation to use IDurableJobRun in return types and parameters |
| src/Orleans.DurableJobs/InMemoryJobQueue.cs | Updated class signature, method signatures, and object instantiation to use IDurableJobRun and DurableJobRun |
| src/Orleans.DurableJobs/IDurableJobReceiverExtension.cs | Updated method parameter types to use IDurableJobRun |
| src/Orleans.DurableJobs/IDurableJobHandler.cs | Renamed interface from IDurableJobContext to IDurableJobRun, renamed class from DurableJobContext to DurableJobRun, and updated all documentation references |
| src/Orleans.DurableJobs/Hosting/DurableJobsOptions.cs | Updated function delegate types to use IDurableJobRun |
| src/Dashboard/Orleans.Dashboard.App/package-lock.json | Added "peer": true flags to multiple package entries (unrelated change) |
Files not reviewed (1)
- src/Dashboard/Orleans.Dashboard.App/package-lock.json: Language not supported
ReubenBond
reviewed
Nov 21, 2025
benjaminpetit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #9750
Microsoft Reviewers: Open in CodeFlow