Skip to content

Conversation

@ledjon-behluli
Copy link
Contributor

@ledjon-behluli ledjon-behluli commented Nov 18, 2025

close #9771

Microsoft Reviewers: Open in CodeFlow

@ledjon-behluli
Copy link
Contributor Author

ledjon-behluli commented Nov 19, 2025

@ReubenBond addressed the comments, PTAL!

WDYT about this, I am unsure, but lean more towards (a)waiting indefinitely

image

@ReubenBond
Copy link
Member

@ledjon-behluli I think relying on them respecting the CT is ok (even if not defensive)

@ledjon-behluli ledjon-behluli marked this pull request as ready for review November 30, 2025 15:15
@ledjon-behluli
Copy link
Contributor Author

ledjon-behluli commented Nov 30, 2025

@ReubenBond Added proper tests & removed the toy/test console app. We should consider not having the TerminateOnError and control it within the component i.e. Starting events should terminate, and while stopping we log and swallow, but other than that this is now ready AFAIC.

P.s: I do not have a strong opinion on the matter of TerminateOnError being an internal thing, or left to the user.

@shacal
Copy link

shacal commented Dec 1, 2025

Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add externally accessible lifecycle events for silos

3 participants