Open
Conversation
The doc claimed "Each element is saved after its initialization" but Seq.init does not cache elements — the initializer function is reapplied on each iteration, same as Seq.initInfinite. Update the description to match actual behavior and add a reference to Seq.cache for users who need cached results. Fixes dotnet#14233
Contributor
|
T-Gro
reviewed
Feb 16, 2026
src/FSharp.Core/seq.fsi
Outdated
| /// | ||
| /// <remarks>The returned sequence may be passed between threads safely. However, | ||
| /// individual IEnumerator values generated from the returned sequence should not be accessed concurrently. This is an O(n) operation, where n is the count.</remarks> | ||
| /// individual IEnumerator values generated from the returned sequence should not be accessed concurrently.</remarks> |
Member
There was a problem hiding this comment.
Please keep the complexity docs. In case of seq, those can be also split into construction complexity and enumeration complexity (expressed in terms of function invocations in this case)
T-Gro
added
the
NO_RELEASE_NOTES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14233
The
Seq.initXML doc claimed "Each element is saved after its initialization" but this is incorrect —Seq.initdoes not cache elements. The initializer function is reapplied on each iteration, exactly likeSeq.initInfinite.Changes:
Seq.initInfinite<see>reference toSeq.cachefor users who need cached resultsinitInfinite)