Skip to content

Fix flaky AsyncType tests by removing premature Task disposal #19274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −10
Open

Fix flaky AsyncType tests by removing premature Task disposal #19274

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7014053
Initial plan
Copilot Feb 11, 2026
d1f2abb
Fix flaky Task disposal in AsyncType.fs tests - change use to let
Copilot Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/FSharp.Core.UnitTests/FSharp.Core/Microsoft.FSharp.Control/AsyncType.fs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ type AsyncType() =
member _.CreateTask () =
let s = "Hello tasks!"
let a = async { return s }
use t : Task<string> = Async.StartAsTask a
let t : Task<string> = Async.StartAsTask a
waitASec t
Assert.True (t.IsCompleted)
Assert.AreEqual(s, t.Result)
Expand All @@ -167,7 +167,7 @@ type AsyncType() =
doSpinloop()
}

use t : Task<unit> = Async.StartAsTask(a, cancellationToken = cts.Token)
let t : Task<unit> = Async.StartAsTask(a, cancellationToken = cts.Token)
// Should not finish, we don't eagerly mark the task done just because it's been signaled to cancel.
try
let result = t.Wait(300)
Expand Down Expand Up @@ -235,7 +235,7 @@ type AsyncType() =
let a = async {
do raise (Exception ())
}
use t = Async.StartAsTask a
let t = Async.StartAsTask a
let mutable exceptionThrown = false
try
// waitASec t
Expand All @@ -250,7 +250,7 @@ type AsyncType() =
let a = async {
while true do ()
}
use t = Async.StartAsTask a
let t = Async.StartAsTask a
Async.CancelDefaultToken ()
let mutable exceptionThrown = false
try
Expand All @@ -270,7 +270,7 @@ type AsyncType() =
}
let cts = new CancellationTokenSource()
let token = cts.Token
use t = Async.StartAsTask(a, cancellationToken=token)
let t = Async.StartAsTask(a, cancellationToken=token)
// printfn "%A" t.Status
ewh.WaitOne() |> Assert.True
cts.Cancel()
Expand All @@ -287,7 +287,7 @@ type AsyncType() =
member _.CreateImmediateAsTask () =
let s = "Hello tasks!"
let a = async { return s }
use t : Task<string> = Async.StartImmediateAsTask a
let t : Task<string> = Async.StartImmediateAsTask a
waitASec t
Assert.True (t.IsCompleted)
Assert.AreEqual(s, t.Result)
Expand All @@ -296,7 +296,7 @@ type AsyncType() =
member _.StartImmediateAsTask () =
let s = "Hello tasks!"
let a = async { return s }
use t = Async.StartImmediateAsTask a
let t = Async.StartImmediateAsTask a
waitASec t
Assert.True (t.IsCompleted)
Assert.AreEqual(s, t.Result)
Expand All @@ -307,7 +307,7 @@ type AsyncType() =
let a = async {
do raise (Exception ())
}
use t = Async.StartImmediateAsTask a
let t = Async.StartImmediateAsTask a
let mutable exceptionThrown = false
try
t.Wait()
Expand All @@ -322,7 +322,7 @@ type AsyncType() =
while true do
do! Async.Sleep 100
}
use t = Async.StartImmediateAsTask a
let t = Async.StartImmediateAsTask a
Async.CancelDefaultToken ()
let mutable exceptionThrown = false
try
Expand All @@ -343,7 +343,7 @@ type AsyncType() =
}
let cts = new CancellationTokenSource()
let token = cts.Token
use t =
let t =
Async.StartImmediateAsTask(a, cancellationToken=token)
ewh.WaitOne() |> Assert.True
cts.Cancel()
Expand Down
Loading