Skip to content

[main] Source code updates from dotnet/dotnet #19216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dotnet-maestro wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[main] Source code updates from dotnet/dotnet #19216

dotnet-maestro wants to merge 5 commits into from
+27 −13

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Jan 15, 2026

Note

This is a codeflow update. It may contain both source code changes from
the VMR
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/dotnet

Associated changes in source repos

Diff the source with this PR branch 
darc vmr diff --name-only https://github.com/dotnet/dotnet:887f3d5a26e1001ee2777afde10cadcacb8cc735..https://github.com/dotnet/fsharp:darc-main-c2cb2ea6-906d-43d6-8e0b-1aaf17d287d6

@dotnet-maestro dotnet-maestro bot requested a review from a team as a code owner January 15, 2026 02:08
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-Gro T-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jan 15, 2026
@github-project-automation github-project-automation bot moved this from New to In Progress in F# Compiler and Tooling Jan 15, 2026
@T-Gro
Copy link
Member

T-Gro commented Jan 15, 2026

/run ilverify

@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

🔧 CLI Command Report

  • Command: /run ilverify
  • Outcome: success

✅ Command succeeded, no changes needed.

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Jan 16, 2026

Important

While this PR was open, the source repository has received code changes from this repository (an opposite codeflow merged).
To avoid complex conflicts, the codeflow cannot continue until this PR is closed or merged.

You can continue with one of the following options:

  • Ignore this and merge this PR as usual without waiting for the new changes.
    Once merged, Maestro will create a new codeflow PR with the new changes.
  • Close this PR and wait for Maestro to open a new one with old and new changes included.
    You will lose any manual changes made in this PR.
    You can also manually trigger the new codeflow right away by running: 
    darc trigger-subscriptions --id 33aad187-a5d7-4947-b09f-777f8ea29e81
  • Force a codeflow into this PR at your own risk if you want the new changes.
    User commits made to this PR might be reverted. 
    darc trigger-subscriptions --id 33aad187-a5d7-4947-b09f-777f8ea29e81 --force

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

T-Gro
T-Gro reviewed Jan 16, 2026
View reviewed changes
eng/Versions.props
<PreReleaseVersionLabel>servicing$(FSharpPreReleaseIteration)</PreReleaseVersionLabel>
<PreReleaseVersionLabel>alpha$(FSharpPreReleaseIteration)</PreReleaseVersionLabel>
<!-- F# Version components -->
<FSMajorVersion>10</FSMajorVersion>
Copy link
Member

@T-Gro T-Gro Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE YET, VS MAPPING TO DECIDE

auduchinok
auduchinok reviewed Jan 16, 2026
View reviewed changes
src/Compiler/Facilities/LanguageFeatures.fs
static let languageVersion110 = 11.0m
static let previewVersion = 9999m // Language version when preview specified
static let defaultVersion = languageVersion100 // Language version when default specified
static let defaultVersion = languageVersion110 // Language version when default specified
Copy link
Member

@auduchinok auduchinok Jan 16, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be updated closer to the release time?

We probably don't want to change the default so early. If I understand it correctly, FCS clients will get the effectively preview language version as default in all projects, unless some language version is specified.

Copy link
Member

@T-Gro T-Gro Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have put this on hold for main for now - I want to fly this config into NET11 SDK preview, so that preview users of NET11SDK do get langversion 11.

But not in other channels, those should stay on 10 as the default.

Copy link
Member

@auduchinok auduchinok Jan 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment was about the tooling using FCS, not about the SDKs. I think we've never changed the default so early previously, and this would be quite unexpected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-Gro T-Gro T-Gro left review comments

@abonie abonie abonie approved these changes

+1 more reviewer

@auduchinok auduchinok auduchinok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@T-Gro @auduchinok @abonie