Skip to content

Remove duplicate command line logging in dotnet-ef Project.FromFile#37658

Closed
Copilot wants to merge 2 commits intoToolingOutputfrom
copilot/sub-pr-37643
Closed

Remove duplicate command line logging in dotnet-ef Project.FromFile#37658
Copilot wants to merge 2 commits intoToolingOutputfrom
copilot/sub-pr-37643

Conversation

Copy link
Contributor

Copilot AI commented Feb 9, 2026

Addresses review feedback from #37643 to eliminate duplicate verbose logging when executing dotnet commands.

Changes

  • Removed manual Reporter.WriteVerbose call in Project.FromFile that logged the command before execution
  • Exe.Run already logs commands via its processCommandLine parameter (defaults to Reporter.WriteVerbose)
  • The manual logging was also using string concatenation without proper quoting, which could be misleading for paths/args containing spaces
// Before: duplicate logging with improper quoting
Reporter.WriteVerbose(Resources.RunningCommand("dotnet " + string.Join(" ", args)));
var exitCode = Exe.Run("dotnet", args, handleOutput: line => output.AppendLine(line));

// After: Exe.Run handles logging with proper quoting via Exe.ToArguments
var exitCode = Exe.Run("dotnet", args, handleOutput: line => output.AppendLine(line));

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: AndriySvyryd <6539701+AndriySvyryd@users.noreply.github.com>
Copilot AI changed the title [WIP] Move Reporter.WriteVerbose to Exe.Run's handleOutput parameter Remove duplicate command line logging in dotnet-ef Project.FromFile Feb 9, 2026
Copilot AI requested a review from AndriySvyryd February 9, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants