Add IsolationLevel overloads to InMemoryTransactionManager#37579
Merged
roji merged 6 commits intodotnet:mainfrom Jan 29, 2026
Merged
Add IsolationLevel overloads to InMemoryTransactionManager#37579roji merged 6 commits intodotnet:mainfrom
roji merged 6 commits intodotnet:mainfrom
Conversation
Add BeginTransaction(IsolationLevel) and BeginTransactionAsync(IsolationLevel, CancellationToken) that delegate to existing parameterless methods, ignoring the isolation level parameter. This makes InMemory provider behavior consistent - transactions are already ignored, so isolation levels should be ignored too instead of throwing.
Add tests for BeginTransaction(IsolationLevel) and BeginTransactionAsync(IsolationLevel).
Merge tests into main feature branch
roji
approved these changes
Jan 29, 2026
Member
roji
left a comment
There was a problem hiding this comment.
Thanks, this really looks to me like it was just an oversight in the original implementation.
Contributor
Author
|
@roji |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add BeginTransaction(IsolationLevel) and BeginTransactionAsync(IsolationLevel) overloads to InMemoryTransactionManager that delegate to existing parameterless methods.
This makes behavior consistent - transactions are already ignored by InMemory provider, so isolation levels should be ignored too instead of throwing.
Ref: dotnet/EntityFramework.Docs#5254 (@roji's comment)