Merged
Conversation
mconnew
approved these changes
Apr 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR is a follow-up to #12467 that restores URL-encoding for # in Markdown <xref:...> links (using %23) so explicit-interface UIDs don’t get interpreted as URL fragments and break xref resolution.
Changes:
- Replaces
#with%23inside affected Markdown<xref:...>links across several XML doc files. - Keeps other previously un-encoded characters (for example,
`and*) unchanged.
Reviewed changes
Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| xml/System.Workflow.Runtime.Hosting/WorkflowWebHostingModule.xml | Re-encodes # in <xref:...> links for explicit IHttpModule members. |
| xml/System.Workflow.Runtime.Hosting/SqlWorkflowPersistenceService.xml | Re-encodes # in <xref:...> links for IPendingWork explicit members. |
| xml/System.Workflow.ComponentModel/ActivityCollection.xml | Re-encodes # in <xref:...> link for ICollection.SyncRoot. |
| xml/System.Workflow.ComponentModel.Serialization/WorkflowMarkupSerializationManager.xml | Re-encodes # in <xref:...> links for IDesignerSerializationManager explicit members/events. |
| xml/System.Workflow.ComponentModel.Design/WorkflowTheme.xml | Re-encodes # in <xref:...> link for IDisposable.Dispose. |
| xml/System.Workflow.ComponentModel.Design/TypeBrowserDialog.xml | Re-encodes # in <xref:...> links for ISite/IServiceProvider explicit members. |
| xml/System.Workflow.ComponentModel.Design/ActivityDesigner.xml | Re-encodes # in <xref:...> links for IDesigner/IRootDesigner explicit members. |
| xml/System.Workflow.Activities/ActiveDirectoryRole.xml | Re-encodes # in <xref:...> link for ISerializable.GetObjectData. |
| xml/System.ServiceModel/WSDualHttpBinding.xml | Re-encodes # in <xref:...> link for IBindingRuntimePreferences.ReceiveSynchronously. |
| xml/System.ServiceModel/MsmqBindingBase.xml | Re-encodes # in <xref:...> link for IBindingRuntimePreferences.ReceiveSynchronously. |
| xml/System.ServiceModel.Dispatcher/MessageFilterTable`1.xml | Re-encodes # in <xref:...> links referencing explicit interface member UIDs. |
| xml/System.ServiceModel.Discovery/DiscoveryServiceExtension.xml | Re-encodes # in <xref:...> link for IServiceBehavior.Validate. |
| xml/System.ServiceModel.Description/ClientCredentials.xml | Re-encodes # in <xref:...> link for IEndpointBehavior.AddBindingParameters. |
| xml/System.ServiceModel.Channels/WebMessageEncodingBindingElement.xml | Re-encodes # in <xref:...> link for IWsdlExportExtension.ExportEndpoint. |
| xml/System.ServiceModel.Channels/TransactionFlowBindingElementImporter.xml | Re-encodes # in <xref:...> link for IPolicyImportExtension.ImportPolicy. |
| xml/System.ServiceModel.Channels/TextMessageEncodingBindingElement.xml | Re-encodes # in <xref:...> links for IWsdlExportExtension methods. |
| xml/System.ServiceModel.Channels/StandardBindingImporter.xml | Re-encodes # in <xref:...> link for IWsdlImportExtension.BeforeImport. |
| xml/System.ServiceModel.Channels/MtomMessageEncodingBindingElement.xml | Re-encodes # in <xref:...> link for IWsdlExportExtension.ExportEndpoint. |
| xml/System.ServiceModel.Channels/MessageEncodingBindingElementImporter.xml | Re-encodes # in <xref:...> link for IWsdlImportExtension.BeforeImport. |
| xml/System.ServiceModel.Channels/IRequestChannel.xml | Re-encodes # in <xref:...> link for IRequestChannel.Request. |
| xml/System.ServiceModel.Channels/IOutputChannel.xml | Re-encodes # in <xref:...> link for IOutputChannel.Send. |
| xml/System.ServiceModel.Channels/ChannelManagerBase.xml | Re-encodes # in <xref:...> links for IDefaultCommunicationTimeouts explicit properties. |
| xml/System.ServiceModel.Channels/ChannelBase.xml | Re-encodes # in <xref:...> links for IDefaultCommunicationTimeouts explicit properties. |
xml/System.Workflow.Runtime.Hosting/SqlWorkflowPersistenceService.xml
Outdated
Show resolved
Hide resolved
gewarren
commented
Apr 2, 2026
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fast follow to #12467.