Skip to content

Don't un-encode ##12482

Merged
gewarren merged 3 commits intodotnet:mainfrom
gewarren:hash-revert
Apr 2, 2026
Merged

Don't un-encode ##12482
gewarren merged 3 commits intodotnet:mainfrom
gewarren:hash-revert

Conversation

@gewarren
Copy link
Copy Markdown
Contributor

@gewarren gewarren commented Apr 2, 2026

Fast follow to #12467.

@gewarren gewarren requested review from a team and mconnew as code owners April 2, 2026 20:13
Copilot AI review requested due to automatic review settings April 2, 2026 20:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is a follow-up to #12467 that restores URL-encoding for # in Markdown <xref:...> links (using %23) so explicit-interface UIDs don’t get interpreted as URL fragments and break xref resolution.

Changes:

  • Replaces # with %23 inside affected Markdown <xref:...> links across several XML doc files.
  • Keeps other previously un-encoded characters (for example, ` and *) unchanged.

Reviewed changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
xml/System.Workflow.Runtime.Hosting/WorkflowWebHostingModule.xml Re-encodes # in <xref:...> links for explicit IHttpModule members.
xml/System.Workflow.Runtime.Hosting/SqlWorkflowPersistenceService.xml Re-encodes # in <xref:...> links for IPendingWork explicit members.
xml/System.Workflow.ComponentModel/ActivityCollection.xml Re-encodes # in <xref:...> link for ICollection.SyncRoot.
xml/System.Workflow.ComponentModel.Serialization/WorkflowMarkupSerializationManager.xml Re-encodes # in <xref:...> links for IDesignerSerializationManager explicit members/events.
xml/System.Workflow.ComponentModel.Design/WorkflowTheme.xml Re-encodes # in <xref:...> link for IDisposable.Dispose.
xml/System.Workflow.ComponentModel.Design/TypeBrowserDialog.xml Re-encodes # in <xref:...> links for ISite/IServiceProvider explicit members.
xml/System.Workflow.ComponentModel.Design/ActivityDesigner.xml Re-encodes # in <xref:...> links for IDesigner/IRootDesigner explicit members.
xml/System.Workflow.Activities/ActiveDirectoryRole.xml Re-encodes # in <xref:...> link for ISerializable.GetObjectData.
xml/System.ServiceModel/WSDualHttpBinding.xml Re-encodes # in <xref:...> link for IBindingRuntimePreferences.ReceiveSynchronously.
xml/System.ServiceModel/MsmqBindingBase.xml Re-encodes # in <xref:...> link for IBindingRuntimePreferences.ReceiveSynchronously.
xml/System.ServiceModel.Dispatcher/MessageFilterTable`1.xml Re-encodes # in <xref:...> links referencing explicit interface member UIDs.
xml/System.ServiceModel.Discovery/DiscoveryServiceExtension.xml Re-encodes # in <xref:...> link for IServiceBehavior.Validate.
xml/System.ServiceModel.Description/ClientCredentials.xml Re-encodes # in <xref:...> link for IEndpointBehavior.AddBindingParameters.
xml/System.ServiceModel.Channels/WebMessageEncodingBindingElement.xml Re-encodes # in <xref:...> link for IWsdlExportExtension.ExportEndpoint.
xml/System.ServiceModel.Channels/TransactionFlowBindingElementImporter.xml Re-encodes # in <xref:...> link for IPolicyImportExtension.ImportPolicy.
xml/System.ServiceModel.Channels/TextMessageEncodingBindingElement.xml Re-encodes # in <xref:...> links for IWsdlExportExtension methods.
xml/System.ServiceModel.Channels/StandardBindingImporter.xml Re-encodes # in <xref:...> link for IWsdlImportExtension.BeforeImport.
xml/System.ServiceModel.Channels/MtomMessageEncodingBindingElement.xml Re-encodes # in <xref:...> link for IWsdlExportExtension.ExportEndpoint.
xml/System.ServiceModel.Channels/MessageEncodingBindingElementImporter.xml Re-encodes # in <xref:...> link for IWsdlImportExtension.BeforeImport.
xml/System.ServiceModel.Channels/IRequestChannel.xml Re-encodes # in <xref:...> link for IRequestChannel.Request.
xml/System.ServiceModel.Channels/IOutputChannel.xml Re-encodes # in <xref:...> link for IOutputChannel.Send.
xml/System.ServiceModel.Channels/ChannelManagerBase.xml Re-encodes # in <xref:...> links for IDefaultCommunicationTimeouts explicit properties.
xml/System.ServiceModel.Channels/ChannelBase.xml Re-encodes # in <xref:...> links for IDefaultCommunicationTimeouts explicit properties.

gewarren and others added 2 commits April 2, 2026 13:30
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@gewarren gewarren merged commit 3b5e925 into dotnet:main Apr 2, 2026
6 checks passed
@gewarren gewarren deleted the hash-revert branch April 2, 2026 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants