-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add note about RID being ignored when publishing for solution #51417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add note about RID being ignored when publishing for solution #51417
Conversation
meaghanlewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BartoszKlonowski thanks for your contribution! I think using the markdown note format makes sense. I applied that as a suggestion along with a few others.
|
|
||
| Publishes the application for a given runtime. For a list of Runtime Identifiers (RIDs), see the [RID catalog](../rid-catalog.md). For more information, see [.NET application publishing overview](../deploying/index.md). If you use this option, use `--self-contained` or `--no-self-contained` also. | ||
|
|
||
| **Note**, that publishing can be done on the *solution* level and on the single *project* level. When publishing from the *solution* level (by specifying optional `<SOLUTION>` parameter or leaving it default) MSBuild first compiles the output into `publish` directory **without** any symbols, which means that later compilations done by MSBuild, based on the initial compilation, will still not include any details for specified `<RUNTIME_IDENTIFIER>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| **Note**, that publishing can be done on the *solution* level and on the single *project* level. When publishing from the *solution* level (by specifying optional `<SOLUTION>` parameter or leaving it default) MSBuild first compiles the output into `publish` directory **without** any symbols, which means that later compilations done by MSBuild, based on the initial compilation, will still not include any details for specified `<RUNTIME_IDENTIFIER>`. | |
| > [!NOTE] | |
| > Publishing can be done on the *solution* level and on the single *project* level. When publishing from the *solution* level by specifying the optional `<SOLUTION>` parameter or leaving it default, MSBuild first compiles the output into the `publish` directory **without** any symbols. This means that later compilations done by MSBuild, based on the initial compilation, will still not include any details for specified `<RUNTIME_IDENTIFIER>`. |
| Publishes the application for a given runtime. For a list of Runtime Identifiers (RIDs), see the [RID catalog](../rid-catalog.md). For more information, see [.NET application publishing overview](../deploying/index.md). If you use this option, use `--self-contained` or `--no-self-contained` also. | ||
|
|
||
| **Note**, that publishing can be done on the *solution* level and on the single *project* level. When publishing from the *solution* level (by specifying optional `<SOLUTION>` parameter or leaving it default) MSBuild first compiles the output into `publish` directory **without** any symbols, which means that later compilations done by MSBuild, based on the initial compilation, will still not include any details for specified `<RUNTIME_IDENTIFIER>`. | ||
| <br/>This is expected behavior, and to avoid it either publish for a single project (by specifying optional `<PROJECT>` parameter) regarding your RID, or specify RIDs directly in the project config by adding [`<RuntimeIdentifiers>`](../project-sdk/msbuild-props.md#runtimeidentifiers) property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| <br/>This is expected behavior, and to avoid it either publish for a single project (by specifying optional `<PROJECT>` parameter) regarding your RID, or specify RIDs directly in the project config by adding [`<RuntimeIdentifiers>`](../project-sdk/msbuild-props.md#runtimeidentifiers) property. | |
| > This is expected behavior. To avoid this behavior either publish for a single project by specifying the optional `<PROJECT>` parameter for your RID or specify RIDs directly in the project config by adding the [`<RuntimeIdentifiers>`](../project-sdk/msbuild-props.md#runtimeidentifiers) property. |
This pull request fixes #50258, by adding the note about RIDs (specified by
-rparam) being "ignored" when publishing for the whole solution.Instead, what is also suggested in the added note, publishing should be done per project regarding specific RIDs details or by specifying RIDs per project using (linked in the note)
<RuntimeIdentifiers>property in the config.I didn't make the note by markdown
> [!NOTE], because I wasn't sure about the layout of bullet points already there, so let me know in comments in case this would be a good idea.Internal previews