Remove SSR buffering by blocking sync context queue during async writes#65206
Draft
Remove SSR buffering by blocking sync context queue during async writes#65206
Conversation
This change removes the need for synchronous buffering when writing SSR render batches to the HTTP response. Instead of buffering content synchronously and then writing it, we now: 1. Move RendererSynchronizationContext and RendererSynchronizationContextDispatcher to shared source (src/Components/Shared/src/) so they can be compiled into both Components and Endpoints assemblies with different namespaces. 2. Add EnqueueBlockingTask(Task) method to RendererSynchronizationContext that inserts a blocking task into the queue, preventing other continuations from running until it completes. 3. Have EndpointHtmlRenderer create its own dispatcher instance so it can access the Endpoints-specific RendererSynchronizationContext. 4. Add WriteContentAsync helper in RazorComponentEndpointInvoker that: - Creates a TaskCompletionSource with RunContinuationsAsynchronously - Enqueues the TCS.Task to block the sync context queue - Writes content asynchronously with ConfigureAwait(false) - Completes the TCS to unblock the queue This approach maintains thread safety (no other continuations can modify state while we write) while allowing async I/O operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the need for synchronous buffering when writing SSR render batches to the HTTP response. The challenge was that we needed to write render batches synchronously because yielding the thread while writing to the output allows other continuations to be scheduled and modify contents between async boundaries.
Solution
Instead of buffering content synchronously and then writing it, we now:
Move shared source files:
RendererSynchronizationContextandRendererSynchronizationContextDispatcherare moved tosrc/Components/Shared/src/so they can be compiled into both Components and Endpoints assemblies with different namespaces (viaCOMPONENTS_ENDPOINTSdefine).Add
EnqueueBlockingTask(Task)method: This method inserts a blocking task into the sync context queue, preventing other continuations from running until it completes.EndpointHtmlRenderer creates its own dispatcher: This allows access to the Endpoints-specific
RendererSynchronizationContextwhich has theEnqueueBlockingTaskmethod.Add
WriteContentAsynchelper: InRazorComponentEndpointInvoker, this helper:TaskCompletionSourcewithRunContinuationsAsynchronouslyConfigureAwait(false)to avoid deadlockBenefits
Testing
HandlesOverlappingStreamingBatchesE2E test (added in Fix corrupted streaming SSR output #50380 to verify streaming SSR output corruption fix) passes