Skip to content

Conversation

@wtgodbe
Copy link
Member

@wtgodbe wtgodbe commented Dec 13, 2025

Copilot fails to build certain projects without the MessagePack submodule checked out

@wtgodbe wtgodbe requested a review from a team as a code owner December 13, 2025 01:36
@github-actions github-actions bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Dec 13, 2025
@wtgodbe wtgodbe merged commit 52230ff into main Dec 13, 2025
15 checks passed
@wtgodbe wtgodbe deleted the wtgodbe/submodules branch December 13, 2025 01:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds submodule checkout configuration to the copilot-setup-steps.yml GitHub Actions workflow file. The repository uses git submodules (googletest and MessagePack-CSharp) which need to be initialized for certain build operations, and this change ensures they are available when Copilot runs setup steps.

  • Adds the submodules: 'true' parameter to the actions/checkout step to enable automatic submodule initialization
  • Ensures the workflow has access to code in the src/submodules directory for build operations

steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v4.2.2
with:
submodules: 'true'
Copy link

Copilot AI Dec 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The submodules parameter should be a boolean value 'true' or 'false', or a string specifying the checkout strategy ('recursive'). While the string 'true' will work, it's more idiomatic in GitHub Actions to use the boolean true without quotes, or use 'recursive' to explicitly check out all nested submodules. Looking at other workflows in the repository (e.g., validate-npm-package-lock-json.yml uses submodules: false), the convention is to use boolean values without quotes.

Suggested change
submodules: 'true'
submodules: true

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants