Skip to content

[ci] Stop using preview .NET SDK channel in two lanes#11510

Merged
simonrozsival merged 1 commit into
mainfrom
jonathanpeppers/turbo-funicular
May 27, 2026
Merged

[ci] Stop using preview .NET SDK channel in two lanes#11510
simonrozsival merged 1 commit into
mainfrom
jonathanpeppers/turbo-funicular

Conversation

@jonathanpeppers
Copy link
Copy Markdown
Member

Component Governance is reporting a vulnerable .NET 10.0 SDK against two lanes in the Xamarin.Android pipeline -- MAUI Integration and Publish symbols and Push to Maestro -- while every other lane reports Fix detected.

Those two lanes were the only ones installing the SDK with DotNetPreviewSdkVersion=10.0 + DotNetPreviewSdkQuality=preview. Now that 10.0 has shipped GA, the preview quality on that channel resolves to a stale pre-GA SDK that never received the security fix that landed in the 10.0 GA SDKs. Every other lane installs DotNetSdkVersion=10.0 + DotNetSdkQuality=GA, which is why CG shows Fix detected for them.

This PR switches both lanes to DotNetSdkVersion / DotNetSdkQuality so they pick up the patched GA SDK like the rest of the pipeline, and removes the now-unused DotNetPreviewSdk* variables so the stale preview channel cannot be reintroduced.

  • Useful description of why the change is necessary.
  • Links to issues fixed
  • Unit tests (N/A -- CI infrastructure only)

The `MAUI Integration` and `Publish symbols and Push to Maestro` jobs were the only two pipeline lanes installing the SDK via `DotNetPreviewSdkVersion=10.0` + `DotNetPreviewSdkQuality=preview`.  Because 10.0 has shipped GA, the `preview` quality on that channel resolves to a stale pre-GA SDK that never received the security fix that landed in the 10.0 GA SDKs.  As a result, Component Governance reports `Fix not detected` for those two lanes while every other lane (which installs `DotNetSdkVersion=10.0` + `DotNetSdkQuality=GA`) reports `Fix detected`.

Switch both lanes to `DotNetSdkVersion` / `DotNetSdkQuality` so they install the patched GA SDK like all the other jobs, and remove the now-unused `DotNetPreviewSdk*` variables so the stale preview channel cannot be reintroduced.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings May 26, 2026 21:47
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Switches two CI lanes (MAUI Integration and Publish symbols/Push to Maestro) from the stale DotNetPreviewSdk* preview channel to the GA DotNetSdk* variables, matching the rest of the pipeline, and removes the now-unused preview variables.

Changes:

  • Replace $(DotNetPreviewSdkVersion)/$(DotNetPreviewSdkQuality) with $(DotNetSdkVersion)/$(DotNetSdkQuality) in the MAUI Integration and Publish-symbols jobs.
  • Remove the unused DotNetPreviewSdkVersion and DotNetPreviewSdkQuality variables from variables.yaml.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
build-tools/automation/yaml-templates/variables.yaml Removes the unused preview SDK channel/quality variables.
build-tools/automation/azure-pipelines.yaml Updates the two affected jobs to use the GA SDK variables.

@simonrozsival simonrozsival merged commit 332c681 into main May 27, 2026
4 checks passed
@simonrozsival simonrozsival deleted the jonathanpeppers/turbo-funicular branch May 27, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants