Skip to content

Conversation

@ds5678
Copy link
Contributor

@ds5678 ds5678 commented Jan 28, 2026

No description provided.

@alinpahontu2912
Copy link
Member

I see we're using TensorIndex.None everywhere else, why is this necessary?

@alinpahontu2912 alinpahontu2912 self-requested a review February 9, 2026 10:54
@ds5678
Copy link
Contributor Author

ds5678 commented Feb 9, 2026

I see we're using TensorIndex.None everywhere else, why is this necessary?

The entire purpose of this unit test is to validate the behavior of TensorIndex.Null. I assume it was just a copy paste mistake when the test was written. It's currently line-for-line identical to the IndexNone test underneath it.

@alinpahontu2912
Copy link
Member

You're right, good catch. I'll merge it

@alinpahontu2912 alinpahontu2912 force-pushed the fix-unit-test-index-null branch from ca89dba to 5f6e95e Compare February 10, 2026 09:16
@ds5678
Copy link
Contributor Author

ds5678 commented Feb 10, 2026

Can you rerun the failed job? I think it was a fluke.

@alinpahontu2912 alinpahontu2912 merged commit b3fe15c into dotnet:main Feb 11, 2026
2 checks passed
@ds5678 ds5678 deleted the fix-unit-test-index-null branch February 11, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants