[3.0] Improve and polish bindings generator#2587
Draft
Exanite wants to merge 17 commits into
Draft
Conversation
Exanite
changed the title
This is be more consistent with C#'s terminology now that ExtractNestedTypes strictly only handles NestedTypes and not other forms of "nested typing".
…t is compilable (if not correct) This is so I can start testing for expected behavior.
…tFunctionPointers/NestedTypes
This also means free performance since Mod sneakily creates a compilation and walks through it
…their extracted files Also add todo for doing the same in ExtractEnumConstants
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of the PR
(WIP)
This will be merged into #2578 and focuses on polishing up the generator, specifically focusing on the issues that I discovered while writing the generator documentation and any other minor generator improvements I decide to include into this PR.
Related issues, Discord discussions, or proposals
Generator documentation PR: #2578
Further Comments
Tasks
ExtractNestedTypingconstant extraction does not handle nor rewrite fields that are typed as a predefined type, but are natively typed as an enum (test case:SuccessfullyExtractsCStyleEnumConstants_Field)ExtractNestedTypingconstant extraction does not handle nor rewrite return types that are typed as a predefined type, but are natively typed as an enum (test case:SuccessfullyExtractsCStyleEnumConstants_ReturnType)ExtractNestedTypingdoes not annotate extracted enums with the[NativeName]attribute. Eg:SDL_BlendMode.IEquatable<T>interface.