chore: Add setting to skip disassembly tests on macos(x64)#3153
Merged
timcassell merged 1 commit intoMay 29, 2026
Merged
Conversation
9ba0c47 to
7ef3a4c
Compare
Contributor
Author
|
Currently following command is silently failed on
It looks like downloaded v8 binary is something wrong.
-> This setting seems not works. jsvu returns exit code 0. And It also confirmed on
|
bcf128b to
489b266
Compare
489b266 to
dc8e2ea
Compare
timcassell
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR add temporary workaround code for #3086
By adding setting to skip disassembly tests on
macos(x64)Currently this SIGSEGV issue is observed on
macos(x64)/CsProjectCoreToolchain only.So just skip related tests on this environment.
Note: As far as I've confirmed, there is no related issue reported on ClrMD repository.