chore: Fix VSTestAdapter throw exception on test discovery for project that targeting net462#2982
Merged
timcassell merged 1 commit intodotnet:masterfrom Jan 28, 2026
Conversation
filzrev
commented
Jan 27, 2026
| { | ||
| return Assembly.LoadFrom(path); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Above code blocks can be simplified without code copy&paste.
But this workaround code is expected to be removed in future when TestAdapter is migrated to use MTPv2 instead of VSTest. So these code are expected to be leave as is.
timcassell
approved these changes
Jan 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR intended to fix following VSTestAdapter issue on net462.
How to reproduce error on VS
BenchmarkDotNet.Samplesproject withReleaseconfiguration on Visual StudioFileLoadExceptionexceptionare recorded on Test output pane on test discovery phase.As far as I've remember.
Test Explorer show benchmarks for
net462previously.So, it's expected to be caused by dependent package version conflict between TestAdaper/BenchmarkDotNet for following packages.
System.Collections.ImmutableSystem.MemoryIt seems not resolved by adding PackageReference to TestAdapter project.
I've added temporary that manually resolve following assemblies by
AppDomain.CurrentDomain.AssemblyResolve.(That is same temporary workaround code that is used to load BenchmarkDotNet.dll for net462)