Blazor Preview 5 patch examples#37252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Blazor QuickGrid documentation samples for .NET 11 Preview 5 by tightening query-string handling and fixing navigation usage in the paging/details examples.
Changes:
- Update the
Details.razorsample to treatId/Pageas nullable query parameters and to generate a “Back to List” link that works whenpageis missing. - Update the
SciFiCharacters.razorsample to injectNavigationManagerand use the injected instance for navigation. - Update the
< aspnetcore-11.0sample to make thePagequery parameter nullable.
Comments suppressed due to low confidence (1)
aspnetcore/blazor/components/quickgrid.md:525
Pageis treated as a 1-based page number, but the code only checksHasValue. If a user supplies?page=0(or a negative value),Page.Value - 1becomes negative and can causeSetCurrentPageIndexAsyncto throw. Guard forPage > 0(or clamp to1) before subtracting.
private int? Page { get; set; }
protected override async Task OnInitializedAsync()
{
if (Page.HasValue)
Collaborator
Author
|
Hold a sec ... I like Copilot's remark ...
UPDATE: Done! 👍 |
Contributor
|
...reviewing.... |
wadepickett
reviewed
Jun 11, 2026
| monikerRange: '>= aspnetcore-8.0' | ||
| ms.author: wpickett | ||
| ms.custom: mvc | ||
| ms.date: 11/11/2025 |
Contributor
There was a problem hiding this comment.
Suggested change
| ms.date: 06/11/2026 |
wadepickett
approved these changes
Jun 11, 2026
wadepickett
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Approved. I reset the ms.date, becuase I could.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #37206
Sorry for the delay, Wade! Great catch on those gremlins 😈!
Please go ahead and merge this if it looks good to you.
Internal previews