Skip to content

Add rate-limiting RetryAfter fixes to What's New for .NET 11 Preview 4#37151

Merged
wadepickett merged 9 commits into
mainfrom
copilot/update-rate-limiting-fixes
May 14, 2026
Merged

Add rate-limiting RetryAfter fixes to What's New for .NET 11 Preview 4#37151
wadepickett merged 9 commits into
mainfrom
copilot/update-rate-limiting-fixes

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented May 14, 2026

Fixes #37150 (Detailed instrucions + parameters were provided there for our custom agent for this repo)

Adds coverage of the System.Threading.RateLimiting fixes from the .NET 11 Preview 4 libraries release notes, reframed for the ASP.NET Core audience.

The source material in dotnet/core is written from the .NET libraries perspective. The include file reframes it from the middleware perspective:

  • Leads with RetryAfter — the most relevant fix for ASP.NET Core developers. FixedWindowRateLimiter now reports accurate RetryAfter metadata, so the rate-limiting middleware automatically sets a meaningful Retry-After response header.
  • Secondary mention of TokenBucketRateLimiter fractional permits and ChainedRateLimiter forwarding fixes.
  • Preserves contributor acknowledgments for @asbjornvad and @apoorvdarshan.

Changes

  • New: aspnetcore/release-notes/aspnetcore-11/includes/rate-limiting-retry-after-preview4.md
  • Updated: aspnetcore/release-notes/aspnetcore-11.md — added [!INCLUDE] in Miscellaneous section, updated ms.date

Internal previews

📄 File 🔗 Preview link
aspnetcore/release-notes/aspnetcore-11.md What's new in ASP.NET Core in .NET 11

Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/ff6f5db4-b8a9-4897-bae7-31d2ce227450

Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com>
Copilot AI changed the title [WIP] Update What's New v11 P4 to include rate-limiting fixes Add rate-limiting RetryAfter fixes to What's New for .NET 11 Preview 4 May 14, 2026
Copilot AI requested a review from wadepickett May 14, 2026 01:30
@wadepickett
Copy link
Copy Markdown
Contributor

@copilot, Check against the code sample used in the source release notes content here:
https://github.com/dotnet/core/blob/main/release-notes/11.0/preview/preview4/libraries.md#rate-limiting-fixes-for-retryafter-fractional-permits-and-chainedratelimiter

Determine why the code example was not included here in the PR, and fix if needed.

Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot, Check against the code sample used in the source release notes content here:
https://github.com/dotnet/core/blob/main/release-notes/11.0/preview/preview4/libraries.md#rate-limiting-fixes-f...

The code sample was omitted in the initial commit because I focused on reframing the prose for the ASP.NET Core audience and didn't carry over the code block. Added it now in commit 1eddbe7 — it shows how a FixedWindowRateLimiter lease exposes the RetryAfter metadata after a failed acquisition.

@wadepickett wadepickett marked this pull request as ready for review May 14, 2026 15:29
@wadepickett wadepickett requested a review from gewarren May 14, 2026 15:33
@wadepickett
Copy link
Copy Markdown
Contributor

wadepickett commented May 14, 2026

Just spotted that I need to adress the cross-link warning from the build:
System.Threading.RateLimiting.ChainedRateLimiter

Switching it to code ticks for now. The API ref is not available yet.

Removing cross-link until <xref:System.Threading.RateLimiting.ChainedRateLimiter%601> is avaialble in API ref build.
Removing code snippet per review suggestion. It is not relevant to the ASP.NET Core rate limiting middleware scenario.
@wadepickett
Copy link
Copy Markdown
Contributor

@copilot, rename this include file from rate-limiting-retry-after-preview4.md to rate-limiting-retry-after-preview-4.md
and then update the link to it from the main article. The build checks do not allow words and numbers to be combined, such as "preview4" without a warning. So it needs to be changed.

…ate reference

Agent-Logs-Url: https://github.com/dotnet/AspNetCore.Docs/sessions/4542cc0b-fadf-40e6-8735-4156936fe239

Co-authored-by: wadepickett <10985336+wadepickett@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented May 14, 2026

@copilot, rename this include file from rate-limiting-retry-after-preview4.md to rate-limiting-retry-after-preview-4.md
and then update the link to it from the main article. The build checks do not ...

Renamed the file and updated the [!INCLUDE] reference in commit 21d9fff.

Copilot AI requested a review from wadepickett May 14, 2026 16:14
@wadepickett wadepickett requested a review from danroth27 May 14, 2026 16:41
@wadepickett
Copy link
Copy Markdown
Contributor

Thanks @danroth27 for the suggested changes. Those are all in now.

Co-authored-by: Daniel Roth <daroth@microsoft.com>
Copy link
Copy Markdown
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@wadepickett wadepickett merged commit 801b9b3 into main May 14, 2026
4 checks passed
@wadepickett wadepickett deleted the copilot/update-rate-limiting-fixes branch May 14, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

What's New v11 P4 - Update to include Rate-limiting fixes from .NET release notes

5 participants