Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ This client has the following external dependencies:
* six v1.8.0+
* python_dateutil v2.5.3+
* setuptools v21.0.0+
* urllib3 v1.15.1+
* urllib3 v2.0.0+
* PyJWT v2.0.0+
* cryptography v2.5+

Expand Down
4 changes: 2 additions & 2 deletions docusign_esign/client/api_response.py
Original file line number Diff line number Diff line change
Expand Up @@ -46,11 +46,11 @@ def __init__(self, resp):

def getheaders(self):
"""Returns a dictionary of the response headers."""
return self.urllib3_response.getheaders()
return self.urllib3_response.headers

def getheader(self, name, default=None):
"""Returns a given response header."""
return self.urllib3_response.getheader(name, default)
return self.urllib3_response.headers.get(name, default)


class RESTClientObject(object):
Expand Down
2 changes: 1 addition & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
# prerequisite: setuptools
# http://pypi.python.org/pypi/setuptools

REQUIRES = ["urllib3 >= 1.15", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=2.0.0", "cryptography>=2.5"]
REQUIRES = ["urllib3 >= 2.0.0, < 3.0.0", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=2.0.0", "cryptography>=2.5"]
Copy link

Copilot AI Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version constraint in the code (>= 2.0.0) does not match what is described in the PR description. The PR description states "Setting a minimum of v2.6.0 ensures users get a mature, stable release" and claims the change ensures "Minimum version is 2.0.0 (stable v2.x release with bug fixes)", but the actual minimum version specified here is 2.0.0, not 2.6.0 as mentioned in the description. If the intent is to require v2.6.0 as the minimum for stability reasons, the constraint should be "urllib3 >= 2.6.0, < 3.0.0" instead.

Suggested change
REQUIRES = ["urllib3 >= 2.0.0, < 3.0.0", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=2.0.0", "cryptography>=2.5"]
REQUIRES = ["urllib3 >= 2.6.0, < 3.0.0", "six >= 1.8.0", "certifi >= 14.05.14", "python-dateutil >= 2.5.3", "setuptools >= 21.0.0", "PyJWT>=2.0.0", "cryptography>=2.5"]

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VDigitall Shouldn't we move to 2.6.0 as minimum version to mitigate CVE-2025-66471

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@garg-mudit
It could be an option, but I added v2.0.0 as it is minimum version that has new methods and it gives other users time to migrate to urllib3 v2.6.0.

To mitigate vulnerability, better would be set minimum version to 2.6.0

But its up to you.


class CleanCommand(Command):
"""Custom clean command to tidy up the project root."""
Expand Down