Add version override #260
Open
Add version override #260
+366
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvoland
force-pushed
the
version-override
branch
2 times, most recently
from
4a69ce1 to
bb2916c
Compare
crazy-max
previously approved these changes
Sep 10, 2025
crazy-max
requested changes
Sep 10, 2025
| FROM src-base AS metadata-builder | ||
| ARG PKG_REPO | ||
| ARG PKG_REF | ||
| ARG PKG_VERSION |
Member
There was a problem hiding this comment.
I think you also need to add it to builder-deb, builder-rpm and builder-static stages. Same for other dockerfiles
pkg/compose/Dockerfile
Outdated
| ARG PKG_NAME="docker-compose-plugin" | ||
| ARG PKG_REPO="https://github.com/docker/compose.git" | ||
| ARG PKG_REF="main" | ||
| ARG PKG_VERSION |
Member
There was a problem hiding this comment.
Not needed to put it there.
Also need to add it to metadata, builder-deb, builder-rpm and builder-static stages.
vvoland
force-pushed
the
version-override
branch
2 times, most recently
from
1d3365c to
9bb37e0
Compare
Allow manual version setting when building. Useful for pre-release testing builds when there's no tag yet. Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
vvoland
force-pushed
the
version-override
branch
from
9bb37e0 to
d41fab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow manual version setting when building. Useful for pre-release testing builds when there's no tag yet.