hack/scripts: strip "v" prefix from version strings #240
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The version generation script was including the 'v' prefix from git tags in generated version strings, which is inconsistent with our current packages. - Tagged releases produce clean version numbers (e.g., "1.0.0" instead of "v1.0.0") - Nightly builds generate pseudo-versions without 'v' prefix Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
Collaborator
Author
crazy-max
approved these changes
Aug 8, 2025
Member
There was a problem hiding this comment.
Don't recall if current logic was based on docker-ce-packaging or containerd-packaging but looks related to docker/docker-ce-packaging@a6aa399
So agree to be consistent LGTM
austinvazquez
approved these changes
Aug 12, 2025
crazy-max
reviewed
Aug 12, 2025
Member
crazy-max
left a comment
crazy-max
left a comment
There was a problem hiding this comment.
Btw on actions-toolkit side we support with and without v prefix for version comparison: https://github.com/docker/actions-toolkit/blob/8b99173e2fc71488f68740756350c02cf10c29d3/src/buildx/buildx.ts#L129
Collaborator
Author
|
Yeah it's not really a blocker, but thought that maybe it would be a good opportunity to actually make it consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version generation script was including the 'v' prefix from git tags in generated version strings, which is inconsistent with our current packages.