ci: open PR in pinata to bump docker-model version#692
Merged
ilopezluna merged 1 commit intomainfrom Feb 18, 2026
Merged
Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- Consider making the script more robust by enabling strict shell options (e.g.,
set -euo pipefail) so failures injq,git, orghcommands abort the job instead of silently continuing. - The job currently assumes the target branch does not already exist; you might want to handle the case where
BRANCHalready exists (e.g., reusing it or failing with a clearer message) to make reruns/idempotency safer. - Before committing, explicitly configuring
gituser.name and user.email in the workflow can avoid failures in environments where these are not preset for the PAT user.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider making the script more robust by enabling strict shell options (e.g., `set -euo pipefail`) so failures in `jq`, `git`, or `gh` commands abort the job instead of silently continuing.
- The job currently assumes the target branch does not already exist; you might want to handle the case where `BRANCH` already exists (e.g., reusing it or failing with a clearer message) to make reruns/idempotency safer.
- Before committing, explicitly configuring `git` user.name and user.email in the workflow can avoid failures in environments where these are not preset for the PAT user.
## Individual Comments
### Comment 1
<location> `.github/workflows/release.yml:511-515` </location>
<code_context>
+ jq --arg v "$NEW_VERSION" '.["docker-model"].version = $v' build.json > build.json.tmp
+ mv build.json.tmp build.json
+
+ BRANCH="bump-docker-model-${NEW_VERSION}"
+ git checkout -b "$BRANCH"
+ git add build.json
+ git commit -m "chore: bump docker-model to ${NEW_VERSION}"
+ git push origin "$BRANCH"
+
+ gh pr create \
</code_context>
<issue_to_address>
**issue:** Configure git user.name/user.email before committing to avoid failures in CI environments.
In CI runners, `git commit` may fail if `user.name` and `user.email` aren’t set. Please configure them explicitly (e.g. `git config user.name "docker-cli-bot"` / `git config user.email "docker-cli-bot@users.noreply.github.com"`) right after cloning so this step doesn’t rely on the runner’s global git config.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
ilopezluna
approved these changes
Feb 18, 2026
0e934e1 to
6f5dab2
Compare
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
6f5dab2 to
eb8d46a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test run: https://github.com/docker/model-runner/actions/runs/22144913411.