Skip to content

ci: open PR in pinata to bump docker-model version#692

Merged
ilopezluna merged 1 commit intomainfrom
release-cli-dd
Feb 18, 2026
Merged

ci: open PR in pinata to bump docker-model version#692
ilopezluna merged 1 commit intomainfrom
release-cli-dd

Conversation

@doringeman
Copy link
Contributor

@doringeman doringeman commented Feb 18, 2026

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • Consider making the script more robust by enabling strict shell options (e.g., set -euo pipefail) so failures in jq, git, or gh commands abort the job instead of silently continuing.
  • The job currently assumes the target branch does not already exist; you might want to handle the case where BRANCH already exists (e.g., reusing it or failing with a clearer message) to make reruns/idempotency safer.
  • Before committing, explicitly configuring git user.name and user.email in the workflow can avoid failures in environments where these are not preset for the PAT user.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making the script more robust by enabling strict shell options (e.g., `set -euo pipefail`) so failures in `jq`, `git`, or `gh` commands abort the job instead of silently continuing.
- The job currently assumes the target branch does not already exist; you might want to handle the case where `BRANCH` already exists (e.g., reusing it or failing with a clearer message) to make reruns/idempotency safer.
- Before committing, explicitly configuring `git` user.name and user.email in the workflow can avoid failures in environments where these are not preset for the PAT user.

## Individual Comments

### Comment 1
<location> `.github/workflows/release.yml:511-515` </location>
<code_context>
+          jq --arg v "$NEW_VERSION" '.["docker-model"].version = $v' build.json > build.json.tmp
+          mv build.json.tmp build.json
+
+          BRANCH="bump-docker-model-${NEW_VERSION}"
+          git checkout -b "$BRANCH"
+          git add build.json
+          git commit -m "chore: bump docker-model to ${NEW_VERSION}"
+          git push origin "$BRANCH"
+
+          gh pr create \
</code_context>

<issue_to_address>
**issue:** Configure git user.name/user.email before committing to avoid failures in CI environments.

In CI runners, `git commit` may fail if `user.name` and `user.email` aren’t set. Please configure them explicitly (e.g. `git config user.name "docker-cli-bot"` / `git config user.email "docker-cli-bot@users.noreply.github.com"`) right after cloning so this step doesn’t rely on the runner’s global git config.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@doringeman doringeman force-pushed the release-cli-dd branch 2 times, most recently from 0e934e1 to 6f5dab2 Compare February 18, 2026 15:55
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@ilopezluna ilopezluna merged commit e574090 into main Feb 18, 2026
11 checks passed
@ilopezluna ilopezluna deleted the release-cli-dd branch February 18, 2026 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments