Skip to content

Fix release workflow#687

Merged
ericcurtin merged 5 commits intomainfrom
fix-release
Feb 18, 2026
Merged

Fix release workflow#687
ericcurtin merged 5 commits intomainfrom
fix-release

Conversation

@ilopezluna
Copy link
Contributor

No description provided.

@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@ilopezluna ilopezluna requested a review from a team February 18, 2026 08:18
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The use of base64 -w 0 is GNU-specific and will fail on macOS/BSD runners; if this workflow might ever run outside of GNU coreutils, consider a more portable approach (e.g., base64 | tr -d '\n') or explicitly constrain the job to a GNU environment.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The use of `base64 -w 0` is GNU-specific and will fail on macOS/BSD runners; if this workflow might ever run outside of GNU coreutils, consider a more portable approach (e.g., `base64 | tr -d '\n'`) or explicitly constrain the job to a GNU environment.

## Individual Comments

### Comment 1
<location> `.github/workflows/release.yml:443` </location>
<code_context>
         run: |
           # Read release notes, base64-encode to safely pass multiline content
-          NOTES_B64=$(base64 < release-notes.md)
+          NOTES_B64=$(base64 -w 0 < release-notes.md)
           echo "changelog_b64=$NOTES_B64" >> "$GITHUB_OUTPUT"

</code_context>

<issue_to_address>
**issue (bug_risk):** Consider portability of `base64 -w 0` across different runner environments.

`-w` is a GNU-specific `base64` flag and isn’t available on macOS/BSD. If this workflow ever runs on a non-GNU runner (e.g., self-hosted macOS), this step will fail. A portable approach is:

```sh
NOTES_B64=$(base64 < release-notes.md | tr -d '\n')
```

This avoids line wrapping without relying on GNU-only options.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ilopezluna ilopezluna changed the title Adding -w 0 disables line wrapping, ensuring the entire base64 string is on a single line. Fix release workflow Feb 18, 2026
@ericcurtin ericcurtin merged commit 4442c87 into main Feb 18, 2026
18 checks passed
@ericcurtin ericcurtin deleted the fix-release branch February 18, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments