Merged
Conversation
…ng is on a single line.
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue, and left some high level feedback:
- The use of
base64 -w 0is GNU-specific and will fail on macOS/BSD runners; if this workflow might ever run outside of GNU coreutils, consider a more portable approach (e.g.,base64 | tr -d '\n') or explicitly constrain the job to a GNU environment.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The use of `base64 -w 0` is GNU-specific and will fail on macOS/BSD runners; if this workflow might ever run outside of GNU coreutils, consider a more portable approach (e.g., `base64 | tr -d '\n'`) or explicitly constrain the job to a GNU environment.
## Individual Comments
### Comment 1
<location> `.github/workflows/release.yml:443` </location>
<code_context>
run: |
# Read release notes, base64-encode to safely pass multiline content
- NOTES_B64=$(base64 < release-notes.md)
+ NOTES_B64=$(base64 -w 0 < release-notes.md)
echo "changelog_b64=$NOTES_B64" >> "$GITHUB_OUTPUT"
</code_context>
<issue_to_address>
**issue (bug_risk):** Consider portability of `base64 -w 0` across different runner environments.
`-w` is a GNU-specific `base64` flag and isn’t available on macOS/BSD. If this workflow ever runs on a non-GNU runner (e.g., self-hosted macOS), this step will fail. A portable approach is:
```sh
NOTES_B64=$(base64 < release-notes.md | tr -d '\n')
```
This avoids line wrapping without relying on GNU-only options.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
doringeman
approved these changes
Feb 18, 2026
-w 0 disables line wrapping, ensuring the entire base64 string is on a single line.
ericcurtin
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.