-
Notifications
You must be signed in to change notification settings - Fork 77
Add script to sync Go version across repo #531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adds sync-go-version.sh to keep Go version consistent across: - go.work, go.mod, cmd/cli/go.mod - Makefiles (based on GO_VERSION variable) - Dockerfiles (based on ARG GO_VERSION) Usage: - check: verify version consistency - sync: update all files to match go.mod Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Summary of ChangesHello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a robust shell script designed to centralize and automate the management of the Go programming language version across the repository. By providing Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `scripts/sync-go-version.sh:72` </location>
<code_context>
+ if ! grep -q "$expected_pattern" "$file"; then
+ local current
+ current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1 || echo "(not found)")
+ echo "Mismatch: $(realpath "$file")"
+ echo " have: $current"
+ echo " want: $expected_value"
</code_context>
<issue_to_address>
**issue (bug_risk):** Using `realpath` can break on systems where it is not available (e.g. some macOS setups).
On systems without `realpath` (notably some macOS setups), this will fail and break the script. Consider a more portable approach (e.g. resolving via a short Python `pathlib.Path(...).resolve()` helper, or a `readlink`/`greadlink`-with-fallback), or simply print `$file`, which is already relative to `REPO_ROOT`.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a very useful shell script to synchronize the Go version across different files in the repository, which will certainly help with consistency. The script is well-structured and follows good practices for shell scripting. I have one suggestion to improve its portability across different operating systems.
Inspired by PR #508, which updates the Go version in a single file.
Once this is merged, I'll use it for that PR.
Adds sync-go-version.sh to keep Go version consistent across:
Usage:
Example (2nd commit):