Skip to content

Conversation

@doringeman
Copy link
Contributor

Inspired by PR #508, which updates the Go version in a single file.
Once this is merged, I'll use it for that PR.

Adds sync-go-version.sh to keep Go version consistent across:

  • go.work, go.mod, cmd/cli/go.mod
  • Makefiles (based on GO_VERSION variable)
  • Dockerfiles (based on ARG GO_VERSION)

Usage:

  • check: verify version consistency
  • sync: update all files to match go.mod

Example (2nd commit):

$ ./scripts/sync-go-version.sh check
Go version from go.mod: 1.24.0

Checking Go version consistency...

Mismatch: /Users/dorin/workspace/model-runner/Makefile
  have: GO_VERSION := 1.23.7
  want: GO_VERSION := 1.24.0

Files are out of sync. Run: ./scripts/sync-go-version.sh sync
$ ./scripts/sync-go-version.sh sync
Go version from go.mod: 1.24.0

Syncing Go version to 1.24.0...

Updated: ./Makefile
  GO_VERSION := 1.23.7 -> GO_VERSION := 1.24.0

Done. Review changes with: git diff

Adds sync-go-version.sh to keep Go version consistent across:
- go.work, go.mod, cmd/cli/go.mod
- Makefiles (based on GO_VERSION variable)
- Dockerfiles (based on ARG GO_VERSION)

Usage:
- check: verify version consistency
- sync: update all files to match go.mod

Signed-off-by: Dorin Geman <dorin.geman@docker.com>
Signed-off-by: Dorin Geman <dorin.geman@docker.com>
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a robust shell script designed to centralize and automate the management of the Go programming language version across the repository. By providing check and sync functionalities, the script ensures that the Go version specified in go.mod is consistently applied to other critical configuration files, such as go.work, cmd/cli/go.mod, Makefiles, and Dockerfiles, thereby streamlining updates and preventing version mismatches.

Highlights

  • New Go Version Sync Script: Introduced scripts/sync-go-version.sh to automate the process of keeping the Go version consistent across go.work, go.mod, cmd/cli/go.mod, Makefiles, and Dockerfiles.
  • Go Version Consistency Checks: The new script includes a check mode to verify if the Go version is consistent across all relevant files, reporting any discrepancies.
  • Automated Go Version Updates: The script provides a sync mode that automatically updates the Go version in specified files to match the version defined in go.mod.
  • Makefile Go Version Update: The Makefile has been updated to reflect the new Go version 1.24.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue

Prompt for AI Agents
Please address the comments from this code review:

## Individual Comments

### Comment 1
<location> `scripts/sync-go-version.sh:72` </location>
<code_context>
+    if ! grep -q "$expected_pattern" "$file"; then
+        local current
+        current=$(grep "$search_pattern" "$file" 2>/dev/null | head -1 || echo "(not found)")
+        echo "Mismatch: $(realpath "$file")"
+        echo "  have: $current"
+        echo "  want: $expected_value"
</code_context>

<issue_to_address>
**issue (bug_risk):** Using `realpath` can break on systems where it is not available (e.g. some macOS setups).

On systems without `realpath` (notably some macOS setups), this will fail and break the script. Consider a more portable approach (e.g. resolving via a short Python `pathlib.Path(...).resolve()` helper, or a `readlink`/`greadlink`-with-fallback), or simply print `$file`, which is already relative to `REPO_ROOT`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a very useful shell script to synchronize the Go version across different files in the repository, which will certainly help with consistency. The script is well-structured and follows good practices for shell scripting. I have one suggestion to improve its portability across different operating systems.

@ericcurtin ericcurtin merged commit fb80c6d into docker:main Dec 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants