chore(lint): enable gci formatter for import grouping

[doringeman]

Configure gci formatter in golangci-lint to enforce consistent import ordering with two groups: stdlib imports first, then all other imports.

[gemini-code-assist]

Summary of Changes

Hello @doringeman, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the gci formatter into the golangci-lint configuration. The primary objective is to establish and enforce a consistent and standardized ordering of Go imports throughout the codebase. This change specifically dictates that standard library imports should precede all other imports, thereby enhancing code readability and maintainability through automated formatting.

Highlights

• GCI Formatter Enabled: The GCI formatter has been enabled within golangci-lint to standardize Go import ordering.
• Import Grouping Configuration: GCI is configured to group standard library imports first, followed by all other imports, ensuring consistent code style.
• Codebase Reformatting: Numerous Go files across the repository have been reformatted to adhere to the new GCI import grouping rules.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[sourcery-ai]

Hey - I've left some high level feedback:

• With both goimports and gci enabled as formatters in .golangci.yml, consider disabling goimports to avoid potential conflicts or double-formatting of imports and let gci be the single source of truth for import ordering.
• If you want to distinguish internal imports from third‑party ones, you might want to extend the gci.sections configuration to include a local section (e.g. matching github.com/docker/model-runner/...) rather than grouping all non‑stdlib imports together.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- With both `goimports` and `gci` enabled as formatters in `.golangci.yml`, consider disabling `goimports` to avoid potential conflicts or double-formatting of imports and let `gci` be the single source of truth for import ordering.
- If you want to distinguish internal imports from third‑party ones, you might want to extend the `gci.sections` configuration to include a local section (e.g. matching `github.com/docker/model-runner/...`) rather than grouping all non‑stdlib imports together.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[gemini-code-assist]

Code Review

This pull request enables the gci formatter to enforce a consistent import order. The changes in the Go files correctly apply the new formatting. However, there is a configuration error in .golangci.yml where the settings for gci are misplaced. I've added a comment with a suggestion to fix it. Once that's addressed, this is a great improvement for code consistency.

[gemini-code-assist]

The settings block for gci is incorrectly placed. According to the golangci-lint documentation, formatter settings should be under a top-level formatters-settings block, not nested within formatters.

Please remove this block and add the settings under formatters-settings like this:

formatters-settings:
  gci:
    sections:
      - standard # stdlib
      - default  # everything else

[doringeman]

That's not true, see https://golangci-lint.run/docs/configuration/file/#formatters-configuration.