Open
Conversation
Just a bit more verbosity that would have made it clear for me. Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
polarathene
suggested changes
Dec 5, 2025
Co-authored-by: Brennan Kinney <5098581+polarathene@users.noreply.github.com> Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Signed-off-by: Marcin Owsiany <porridge@redhat.com>
Author
|
PTAL @polarathene |
polarathene
approved these changes
Dec 8, 2025
polarathene
left a comment
polarathene
left a comment
There was a problem hiding this comment.
LGTM 👍
I'm not sure if swapping the true|false value list to false|true will be inferred that way, conventionally you'd refer to booleans as true false, so it just reads a bit weird the other way around 😅
The latest setting would now also differ in the value list arrangement, although it does have auto as the first value which just happens to be it's default too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bit would have let me avoid having to file #567
Fixes: #567