pass args by array, tighten regex used in verification #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
bobcallaway
force-pushed
the
regexp_escape
branch
from
8056ceb to
42f641f
Compare
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Signed-off-by: Bob Callaway <bob.callaway@gmail.com>
Member
|
Thanks but seems this was related to an issue with github artifacts, see #29 (comment) |
Author
Good catch on the root cause; I still think the regex should be tightened down a bit more to address special characters in the url |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure this is the root cause of #29 but I think it will remove shell expansion from
exec.execas a potential cause of the flakiness. I also tightened down the regexp used during verification to force it to come from a ref off of the specific files.@crazy-max @haydentherapper fyi