Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
craig-osterhout
left a comment
There was a problem hiding this comment.
Thanks @brandonh6k. It looks like the v10 DHI images just dropped. Suggest updating to those, or somehow make sure the v9 build will work with the updated sample app.
|
@craig-osterhout Thanks for the review. I've pushed a new change to the guide that incorporates all of those changes. Also, I extended the DHI tabbing through the rest of the guide (the Develop and Run Test pages) for consistency. |
|
Thanks @brandonh6k. Sorry, we had to quietly pause all reviews/changes for the surprise DHI free updates. Can you help update this based on that? |
craig-osterhout
left a comment
There was a problem hiding this comment.
Marking as changes requested.
|
/review |
There was a problem hiding this comment.
Documentation Review Summary
Reviewed the .NET 10 update and DHI integration changes. Found one unrelated change that should be removed.
Issues Found
- HIGH: Unrelated .gitignore changes should be removed
The documentation updates for .NET 10 and Docker Hardened Images look good overall. The content is clear, accurate, and follows the established patterns.
|
Addressed Reviewer Bot comment. |
Description
Errr... I updated the .NET guide to 10. 😆
Related issues or tickets
The sample .NET repo has a PR as well - docker/docker-dotnet-sample#9
Reviews