Skip to content

Conversation

@austinvazquez
Copy link
Contributor

- What I did
This change adds the nri_no_wasm build tag for docker engine builds. Reference: https://github.com/containerd/nri/blob/1078130fa016884b4c03880d9d587e6691a67d98/README.md#webassembly-support

- Description for the changelog

@thaJeztah
Copy link
Member

Looks like you only updated the RPM dockerfiles, not the DEB ones https://github.com/docker/docker-ce-packaging/tree/master/deb

Probably we need changes in either moby, or the static scripts used here (or both)

https://github.com/docker/docker-ce-packaging/blob/9b4db1ea45d9075778bc56e5ef01c0f9bad64281/static/Makefile

@austinvazquez
Copy link
Contributor Author

austinvazquez commented Dec 18, 2025

Weird plucky amd64 is having issues but arm build is working fine. Need to look into it further.

Edit: oop, UI just refreshed when I commented. I'll look into it @thaJeztah 👍🏼

@thaJeztah
Copy link
Member

Plucky looks like an issue on their side (I went looking if it was already EOL, but looks like it's still supported til January)

Either that, or perhaps some bad mirror state

@austinvazquez
Copy link
Contributor Author

I'm leaning towards bad mirror bc I noticed arm is fine; only x86 is not happy. 😅

This change adds the `nri_no_wasm` build tag for docker engine builds.
Reference: https://github.com/containerd/nri/blob/1078130fa016884b4c03880d9d587e6691a67d98/README.md#webassembly-support

Signed-off-by: Austin Vazquez <austin.vazquez@docker.com>
@vvoland
Copy link
Contributor

vvoland commented Dec 19, 2025

Actually, we don't need to do it on the packaging repo side if we just disable it in the moby build script itself.
Opened a PR: moby/moby#51772

@austinvazquez
Copy link
Contributor Author

Closing in favor of moby/moby#51772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants