-
Notifications
You must be signed in to change notification settings - Fork 375
refactor(coder): use first_available model selection with multi-provider fallbacks #2996
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,16 @@ | ||
| models: | ||
| default: | ||
| provider: anthropic | ||
| model: claude-opus-4-6 | ||
| haiku: | ||
| provider: anthropic | ||
| model: claude-haiku-4-5 | ||
| first_available: | ||
| - anthropic/claude-opus-4-8 | ||
| - openai/gpt-5.5 | ||
| - google/gemini-3.5-flash | ||
| - dmr/ai/qwen3 | ||
| fast: | ||
| first_available: | ||
| - anthropic/claude-haiku-4-5 | ||
| - openai/gpt-5.4-mini | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [MEDIUM] Unrecognized model IDs in
As with the
|
||
| - google/gemini-3.1-flash-lite | ||
| - dmr/ai/qwen3 | ||
|
|
||
| agents: | ||
| root: | ||
|
|
@@ -185,7 +191,7 @@ agents: | |
| agent: root | ||
|
|
||
| librarian: | ||
| model: haiku | ||
| model: fast | ||
| description: Web Researcher | ||
| instruction: | | ||
| You search the web for documentation, articles, and technical references. | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[MEDIUM] Speculative model IDs in
defaultfirst_available list may cause runtime API failuresThe new
defaultmodel candidates includeanthropic/claude-opus-4-8,openai/gpt-5.5, andgoogle/gemini-3.5-flash. None of these are known public model identifiers. Thefirst_availableselector picks the first candidate whose credentials are configured — not whether the model ID is valid — so a user with Anthropic credentials will always resolve toanthropic/claude-opus-4-8, and the subsequent API call will fail if Anthropic's API does not recognize that model ID.The old config used
claude-opus-4-6(also non-public), so this project likely uses pre-release/internal model names. If these are intentional internal identifiers, this is expected. If they are typos or speculative future names, users with cloud credentials will get runtime failures instead of a working fallback — the localdmr/ai/qwen3fallback is only reached when no cloud credentials are configured at all.Consider verifying these model IDs against the provider's current API catalog (e.g., Anthropic's model list, OpenAI's
/v1/models, Google's Gemini API).