fix: prevent infinite loop when context overflow compaction fails#2235
Draft
dgageot wants to merge 1 commit intodocker:mainfrom
Draft
fix: prevent infinite loop when context overflow compaction fails#2235dgageot wants to merge 1 commit intodocker:mainfrom
dgageot wants to merge 1 commit intodocker:mainfrom
Conversation
When a ContextOverflowError occurs and session compaction is enabled, the runtime retries after compacting. If compaction fails to reduce the context enough, the same overflow recurs, causing an infinite loop. Add a compactionAttempted guard that allows only one compaction attempt per overflow. The guard resets after a successful model call so future overflows can still trigger compaction. Assisted-By: docker-agent
aheritier
approved these changes
Mar 24, 2026
![docker-agent[bot]](https://avatars.githubusercontent.com/in/2787757?s=60&v=4){kind=small}
There was a problem hiding this comment.
Assessment: 🟢 APPROVE
This PR correctly implements infinite loop prevention for context overflow compaction. The compactionAttempted flag is properly scoped as a local variable within RunStream(), ensuring:
- ✅ No race conditions (local variable, single goroutine)
- ✅ Proper reset between invocations (re-initialized on each call)
- ✅ Correct reset after successful model calls (line 326)
- ✅ Adequate test coverage with
TestContextOverflow_NoInfiniteLoop
The implementation is clean and follows Go best practices. No bugs found in the changed code.
gtardif
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ContextOverflowError occurs and session compaction is enabled, the runtime retries after compacting. If compaction fails to reduce the context enough, the same overflow recurs, causing an infinite loop.
Add a compactionAttempted guard that allows only one compaction attempt per overflow. The guard resets after a successful model call so future overflows can still trigger compaction.
Assisted-By: docker-agent