cli-plugins/manager: remove legacy system-wide cli-plugin path #6713
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 4d3a76d updated the list of directories for discovering CLI plugins, adding `%ProgramFiles%\Docker\cli-plugins` for system-wide plugins. For backward compatibility, the `%PROGRAMDATA%\Docker\cli-plugins` was kept, however, this location is no longer used, and not generally recommended for storing non-data content (such as CLI plugin binaries). From the [ProgramData] documentation: > ProgramData specifies the path to the program-data folder (normally C:\ProgramData). > Unlike the Program Files folder, this folder can be used by applications to store > data for standard users, because it does not require elevated permissions. It also mentions "It can’t contain any serviceable components.", effectively meaning that these paths should not contain data that is managed (through updates etc.), making it a poor choice for installing "system wide" CLI plugins. This patch removes the path from the list, given that this location is no longer used by Docker Desktop, and the CLI-plugin API is considered an internal implementation (since 459c608). [ProgramData]: https://learn.microsoft.com/en-us/windows-hardware/customize/desktop/unattend/microsoft-windows-shell-setup-folderlocations-programdata Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thaJeztah
added
impact/changelog
kind/refactor
robmry
approved these changes
Dec 18, 2025
Member
Author
|
Thx! I'll bring this one in, but feel free to tweak the release-notes, @vvoland |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 4d3a76d updated the list of directories for discovering CLI plugins, adding
%ProgramFiles%\Docker\cli-pluginsfor system-wide plugins.For backward compatibility, the
%PROGRAMDATA%\Docker\cli-pluginswas kept, however, this location is no longer used, and not generally recommended for storing non-data content (such as CLI plugin binaries). From the ProgramData documentation:It also mentions "It can’t contain any serviceable components.", effectively meaning that these paths should not contain data that is managed (through updates etc.), making it a poor choice for installing "system wide" CLI plugins.
This patch removes the path from the list, given that this location is no longer used by Docker Desktop, and the CLI-plugin API is considered an internal implementation (since 459c608).
- What I did
- How I did it
- How to verify it
- Human readable description for the release notes
- A picture of a cute animal (not mandatory but encouraged)