Skip to content

Conversation

@craig-osterhout
Copy link
Contributor

- What I did
Fixed some typos and updated some formatting in the docs.

- How I did it

- How to verify it

- Description for the changelog

Fix typos and update formatting in docs.

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2023

Codecov Report

Merging #4715 (3557b2b) into master (8f90d98) will decrease coverage by 0.02%.
Report is 16 commits behind head on master.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4715      +/-   ##
==========================================
- Coverage   59.68%   59.66%   -0.02%     
==========================================
  Files         287      287              
  Lines       24865    24760     -105     
==========================================
- Hits        14841    14774      -67     
+ Misses       9138     9100      -38     
  Partials      886      886              

@thaJeztah
Copy link
Member

Oh! I think this is gonna conflict with @dvdksn's PR; 🙈

@dvdksn can you help out, and see how to combine both? 🙈 ❤️

@thaJeztah thaJeztah added this to the 25.0.0 milestone Dec 14, 2023
@dvdksn
Copy link
Contributor

dvdksn commented Dec 14, 2023

@thaJeztah no I think we are safe - they shouldn't be touching the same files

@thaJeztah
Copy link
Member

Ah, that's great! I saw the kind of changes and though....oh no!

If you can help review; that'd be appreciated 🤗

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some comments, no big ones, and not all actionable (I plead guilty to thinking out loud)

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cc @thaJeztah

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah it needs to be squashed

dvdksn
dvdksn previously requested changes Dec 18, 2023
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash

```

In addition to _running_ tasks, the output also shows the task history. For
In addition to running tasks, the output also shows the task history. For
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the emphasis on "running" here was to prevent it being confused for "The command allows you to run tasks".

This could be "In addition to tasks that are running" or something along those lines, but we can revisit that in a follow-up.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll do a quick squash

Co-authored-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Signed-off-by: Craig Osterhout <craig.osterhout@docker.com>
@thaJeztah thaJeztah dismissed dvdksn’s stale review December 19, 2023 18:32

commits were squashed

@thaJeztah thaJeztah merged commit 50ad446 into docker:master Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants