Skip to content

metrics-addr is not experimental anymore since 20.10 #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
u1735067 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

metrics-addr is not experimental anymore since 20.10 #4391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions docs/reference/commandline/dockerd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,6 @@ the `--cgroup-parent` option on the daemon.
#### Daemon metrics

The `--metrics-addr` option takes a tcp address to serve the metrics API.
This feature is still experimental, therefore, the daemon must be running in experimental
mode for this feature to work.

To serve the metrics API on `localhost:9323` you would specify `--metrics-addr 127.0.0.1:9323`,
allowing you to make requests on the API at `127.0.0.1:9323/metrics` to receive metrics in the
Expand All @@ -906,10 +904,6 @@ scrape_configs:
- targets: ['127.0.0.1:9323']
```

Please note that this feature is still marked as experimental as metrics and metric
names could change while this feature is still in experimental. Please provide
feedback on what you would like to see collected in the API.

Comment on lines -909 to -912
Copy link
Member

@thaJeztah thaJeztah Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want to keep some wording about this.

The TL;DR is that we removed the experimental gate on the daemon side for the metrics socket, because we saw no strong motivation to require both the experimental option to be set, and setting the option for the metrics-address.

That said, naming of metrics may still change (also see moby/moby#27307); an initial set of metrics implemented, and the original plan was to add / change those based on feedback (we didn't get a lot of that, and I don't think here's been much activity around it).

Copy link
Contributor

@dvdksn dvdksn Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say fine to remove this. The docs shouldn't discuss things that may or may not happen in the future.

#### Node Generic Resources

The `--node-generic-resources` option takes a list of key-value
Expand Down