policy: fix concurrent open waiter deadlock in sourcemeta Resolver#3659
Closed
crazy-max wants to merge 1 commit intodocker:masterfrom
Closed
policy: fix concurrent open waiter deadlock in sourcemeta Resolver#3659crazy-max wants to merge 1 commit intodocker:masterfrom
crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
sourcemeta-deadlock
branch
from
6cf40e8 to
1bcb43a
Compare
Member
|
I already had a patch for this in 675ceb5 |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #3658
This PR removes a deadlock in
util/sourcemeta.Resolver.open(). Under concurrent calls, only one goroutine could receive fromr.readywhile others waited forever; on Windows this race was easier to hit and caused the 30m timeout encountered in #3658. The change adds a one-time open-complete broadcast (opened) that is closed when open succeeds or fails, so all waiters wake up, re-check shared state, and return without blocking.Can be tested with: