Add support for native grpc on the docker socket #3369
+43
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Derek McGowan <derek@mcg.dev>
thaJeztah
force-pushed
the
support-native-docker-grpc
branch
from
8f5fb52 to
36788c6
Compare
Member
|
Did a quick rebase to get a fresh run of CI, and moved it out of draft after moby/moby#50744 was merged / accepted. |
thaJeztah
reviewed
Dec 12, 2025
Comment on lines
+83
to
+86
| if err != nil { | ||
| opts = append([]client.ClientOpt{ | ||
| client.WithContextDialer(func(context.Context, string) (net.Conn, error) { | ||
| return d.Dial(ctx) |
Member
There was a problem hiding this comment.
Should we add some comment to describe that this is the fallback for the legacy approach @akerouanton (Which could include a link to the moby PR), so that we know when we could potentially remove the fallback?
fenollp
reviewed
Dec 12, 2025
Comment on lines
+74
to
+83
| c, err = client.New(ctx, d.DockerAPI.DaemonHost(), opts...) | ||
| workers []*client.WorkerInfo | ||
| ) | ||
| if err == nil { | ||
| workers, err = c.ListWorkers(ctx) | ||
| if err != nil { | ||
| c.Close() | ||
| } | ||
| } | ||
| if err != nil { |
There was a problem hiding this comment.
Drive by review:
Is this not missing a return after c.Close()? Here the second if err != nil { can happen after ListWorkers and it does not look like that is the actual intent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.