Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 29/cli/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion 29/dind/Dockerfile

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Dockerfile-cli.template
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ include "shared" -}}
FROM alpine:3.22
FROM alpine:3.23

RUN apk add --no-cache \
ca-certificates \
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile-dind.template
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ RUN set -eux; \
ip6tables-restore \
; do \
# "iptables-save" -> "iptables-legacy-save", "ip6tables" -> "ip6tables-legacy", etc.
# https://pkgs.alpinelinux.org/contents?branch=v3.22&name=iptables-legacy&arch=x86_64
# https://pkgs.alpinelinux.org/contents?branch=v3.23&name=iptables-legacy&arch=x86_64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oof, this isn't right - iptables-legacy appears to be gone now? why was the build successful? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/docker-library/docker/actions/runs/19907298248/job/57066878833#step:5:299

squint

#9 0.513 (3/3) Installing iptables-legacy (1.8.11-r1)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, I guess this is just a case of pkgs.alpinelinux.org not being updated yet?

$ docker run -it --rm --pull=always alpine:3.23
3.23: Pulling from library/alpine
Digest: sha256:51183f2cfa6320055da30872f211093f9ff1d3cf06f39a0bdb212314c5dc7375
Status: Image is up to date for alpine:3.23
/ # apk add --no-cache iptables-legacy
(1/4) Installing libip4tc (1.8.11-r1)
(2/4) Installing libip6tc (1.8.11-r1)
(3/4) Installing libxtables (1.8.11-r1)
(4/4) Installing iptables-legacy (1.8.11-r1)
Executing busybox-1.37.0-r29.trigger
OK: 8 MiB in 20 packages

🤷

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I just 'gambled' with the URL, weird that it's still not there. Seems like the same thing happened last time around:
#539 (comment)

I did look at edge and figured as long as it still appears there, it will likely still be around in the stable releases.

b="$(command -v "${f/tables/tables-legacy}")"; \
"$b" --version; \
ln -svT "$b" "/usr/local/sbin/.iptables-legacy/$f"; \
Expand Down
Loading