Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Description:
This PR enhances the
reportingmodule by adding robust test coverage, runtime benchmarking, code quality safeguards, and improved CI pipeline integration.🧪 Tests Added:
Unit tests for
ReportValidators.jasperand.jrxmlhandlingInputStream,byte[])Unit tests for
ReportExporterUnit tests for
ReportGeneratorgetDataRows()Verified thrown exceptions match expected types (including
NullPointerExceptionas cause inRuntimeException)🚀 Enhancements:
Benchmarking
ReportGenerator.generateReport()to measure execution duration in milliseconds.Coverage Enforcement
Updated Maven config and GitHub Actions to:
mvn verify⚙️ CI Pipeline Changes (
.github/workflows/test-feature.yml):jacoco:reportandjacoco:checktomvncommandminimumLineCoverage=0.80target/site/jacoco/index.html📊 How to View Coverage
After running:
Open this file:
📎 Notes
commons-loggingwere resolved by avoiding duplicate classpath entries.ReportGeneratorto ensure internal failures don’t propagate unchecked.Let me know if you'd like to split this PR or further document anything!