make sure renew service user has proper name

[zluudg]

Summary by CodeRabbit

• Chores
  • Updated system user configuration for the installation process.

[coderabbitai]

Walkthrough

The Debian post-installation script is updated to rename the system user for renewal tasks from "tapir-renew" to "dnstapir-renew", maintaining the same group assignment and functionality.

Changes

Cohort / File(s)	Change Summary
User Renaming in Debian Post-Install Script deb/DEBIAN/postinst	Renamed renewal system user from tapir-renew to dnstapir-renew

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A tapir once named for renewal's task,
Now dressed in dnstapir's fresh mask,
Same purpose, new identity bright,
The postinst script sets things right, 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'make sure renew service user has proper name' directly relates to the main change: renaming the renewal service user from 'tapir-renew' to 'dnstapir-renew' in the postinst script.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch leon/fix-bad-service-user

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between db001e3 and ab7369e.

📒 Files selected for processing (1)

• deb/DEBIAN/postinst (1 hunks)

🧰 Additional context used

🧠 Learnings (5)

📓 Common learnings

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/tapir-renew.service:0-0
Timestamp: 2025-08-19T08:25:08.604Z
Learning: User zluudg in dnstapir/cli decided to skip failure gating for tapir-restartpop.service, preferring simplicity over complex error handling when automatically triggering service restarts after certificate renewal.

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/tapir-renew.service:5-6
Timestamp: 2025-08-19T07:59:26.767Z
Learning: The user (zluudg) in dnstapir/cli wants automatic pull-in of tapir-restartpop.service when tapir-renew.service is activated, with failure gating to prevent restarts on failed renewals. This updates the previous preference for manual-only activation.

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/restart-pop.service:11-11
Timestamp: 2025-08-14T11:59:39.396Z
Learning: The restart-pop.service in dnstapir/cli is intended as an optional, manually-activated workaround for restarting tapir-pop.service after certificate renewal. The user (zluudg) prefers to keep tapir-renew.service untouched and is okay with manual activation rather than automatic triggering.

📚 Learning: 2025-08-19T08:25:08.604Z

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/tapir-renew.service:0-0
Timestamp: 2025-08-19T08:25:08.604Z
Learning: User zluudg in dnstapir/cli decided to skip failure gating for tapir-restartpop.service, preferring simplicity over complex error handling when automatically triggering service restarts after certificate renewal.

Applied to files:

• deb/DEBIAN/postinst

📚 Learning: 2025-08-19T07:59:26.767Z

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/tapir-renew.service:5-6
Timestamp: 2025-08-19T07:59:26.767Z
Learning: The user (zluudg) in dnstapir/cli wants automatic pull-in of tapir-restartpop.service when tapir-renew.service is activated, with failure gating to prevent restarts on failed renewals. This updates the previous preference for manual-only activation.

Applied to files:

• deb/DEBIAN/postinst

📚 Learning: 2025-08-14T11:59:39.396Z

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SOURCES/restart-pop.service:11-11
Timestamp: 2025-08-14T11:59:39.396Z
Learning: The restart-pop.service in dnstapir/cli is intended as an optional, manually-activated workaround for restarting tapir-pop.service after certificate renewal. The user (zluudg) prefers to keep tapir-renew.service untouched and is okay with manual activation rather than automatic triggering.

Applied to files:

• deb/DEBIAN/postinst

📚 Learning: 2025-08-14T12:03:40.980Z

Learnt from: zluudg
Repo: dnstapir/cli PR: 41
File: rpm/SPECS/tapir-cli.spec:42-42
Timestamp: 2025-08-14T12:03:40.980Z
Learning: User zluudg prefers not to auto-start or auto-enable systemd services in the dnstapir/cli RPM package, preferring manual activation instead.

Applied to files:

• deb/DEBIAN/postinst

🔇 Additional comments (1)

deb/DEBIAN/postinst (1)

5-5: The review comment is based on incorrect assumptions and should be ignored.

The search reveals that "tapir-renew" does not exist anywhere in the codebase—no historical references, no current usage, and no legacy references in git history. All references consistently use "dnstapir-renew" across the entire project (service files, RPM specs, postinst script, and Makefile).

The deb/DEBIAN/postinst file at line 5 already uses the correct and consistent username "dnstapir-renew". There is no username change occurring here, and no migration logic is needed because there is no old username to migrate from. This is not a breaking change.

Likely an incorrect or invalid review comment.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[eest]

LGTM