HTML API: Add spawn fragment parser method#22
Closed
sirreal wants to merge 12 commits intodmsnell:html-api/set-inner-htmlfrom
Closed
HTML API: Add spawn fragment parser method#22sirreal wants to merge 12 commits intodmsnell:html-api/set-inner-htmlfrom
sirreal wants to merge 12 commits intodmsnell:html-api/set-inner-htmlfrom
Conversation
sirreal
force-pushed
the
html-api/spawn_fragment_parser
branch
from
3865260 to
c621467
Compare
This was referenced Sep 12, 2024
sirreal
commented
Sep 12, 2024
| private function spawn_fragment_parser( string $html ): ?self { | ||
| if ( $this->get_token_type() !== '#tag' ) { | ||
| return null; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
This should probably bail on closers too.
Maybe bail on virtual tokens?
sirreal
changed the title
When fragments were used instead of full processors, some fake tree structure had to be prepended to the output. This is no longer necessary and breaks the fragment cases.
This condition: > Reprocess the token according to the rules given in the section > corresponding to the current insertion mode in HTML content. Was resulting in an infinite loop in fragment cases. In full documents, after popping nodes the context is always moved so that foreign content parsing is not used. This is not guaranteed in a fragment and could cause an infinite loop.
Collaborator
Author
|
Proposed on its own in WordPress#7348 |
12 tasks
Collaborator
Author
|
Closing in favor of WordPress#7348 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements https://html.spec.whatwg.org/multipage/parsing.html#html-fragment-parsing-algorithm
Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.