Draft
Conversation
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
from
6698cd9 to
43db05f
Compare
dmsnell
force-pushed
the
html-api/add-comments-and-test-case
branch
from
586b335 to
c86eeb2
Compare
dmsnell
force-pushed
the
html-api/add-get-set-inner-outer-contents
branch
from
43db05f to
79bf013
Compare
dmsnell
changed the base branch from
html-api/add-get-set-inner-outer-contents
to
trunk
dmsnell
changed the title
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will probably be split before merging. In the process of expanding some comments I discovered that the HTML Processor allows moving forward after finding unsupported HTML, and a new test was added to prevent this. Additionally, it reports a tag name after failing on unsupported HTML, which probably needs to be fixed in the Tag Processor, or through new logic in
WP_HTML_Processor::get_tag()to refuse to return results if there's a parse failure. This could get complicated with reporting attributes and all.