Skip to content

Fix #526, support int*[0].init#531

Merged
WebFreak001 merged 3 commits intodlang-community:masterfrom
0-v-0:fix-526
Apr 9, 2026
Merged

Fix #526, support int*[0].init#531
WebFreak001 merged 3 commits intodlang-community:masterfrom
0-v-0:fix-526

Conversation

@0-v-0
Copy link
Copy Markdown
Contributor

@0-v-0 0-v-0 commented Apr 7, 2026

No description provided.

Comment thread src/dparse/parser.d Outdated
Comment thread src/dparse/parser.d Outdated
Comment thread src/dparse/parser.d Outdated
Comment thread src/dparse/parser.d Outdated
{
auto bookmark = setBookmark();
auto c = allocator.setCheckpoint();
if (auto t = parseType())
Copy link
Copy Markdown
Member

@WebFreak001 WebFreak001 Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the condition always returns true (must be Type -> Type2 -> BuiltinType at this point due to the current token being one of BasicTypes and then the parseType does not require any further things)

Also removes the need for bookmark/checkpoint

Additionally for backwards compatibility add a getter function in ast.d in PrimaryExpression, which returns type?.type2?.builtinType ?? IdType.init

0-v-0 and others added 2 commits April 9, 2026 16:48
Co-authored-by: Jan Jurzitza <gh@webfreak.org>
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 9, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.81%. Comparing base (ddddc86) to head (cb77def).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
src/dparse/ast.d 80.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   84.68%   84.81%   +0.13%     
==========================================
  Files          11       11              
  Lines        8565     8812     +247     
==========================================
+ Hits         7253     7474     +221     
- Misses       1312     1338      +26     
Files with missing lines Coverage Δ
src/dparse/parser.d 92.64% <100.00%> (-0.15%) ⬇️
src/dparse/ast.d 70.00% <80.00%> (-0.19%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b0a901...cb77def. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@WebFreak001 WebFreak001 merged commit 6ed852f into dlang-community:master Apr 9, 2026
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants